Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assertion Error with del_series #110

Closed
CodedNil opened this issue Jun 27, 2022 · 3 comments · Fixed by #112
Closed

Assertion Error with del_series #110

CodedNil opened this issue Jun 27, 2022 · 3 comments · Fixed by #112
Assignees
Labels
type/bug Something isn't working

Comments

@CodedNil
Copy link

When I run sonarrapi.del_series(id, delete_files=True) I get this error:
Traceback (most recent call last):
File "/home/dan/Sheetarr/sheetarr.py", line 657, in
sonarrapi.del_series(id, delete_files=True)
File "/home/dan/.local/lib/python3.9/site-packages/pyarr/sonarr.py", line 478, in del_series
return self.delete(f"series/{id}", self.ver_uri, params=params)
File "/home/dan/.local/lib/python3.9/site-packages/pyarr/request_handler.py", line 189, in _delete
return self._return(res, Response)
File "/home/dan/.local/lib/python3.9/site-packages/pyarr/request_handler.py", line 202, in _return
assert isinstance(response, arg1)
AssertionError

The series is successfully deleted from sonarr though

@github-actions
Copy link

Hello @CodedNil, thank you for your interest in our work!

If this is a bug report, please provide screenshots and minimum viable code to reproduce your issue, otherwise we can not help you.

@marksie1988 marksie1988 self-assigned this Jun 27, 2022
@marksie1988 marksie1988 added the type/bug Something isn't working label Jun 27, 2022
@github-actions
Copy link

Branch 110-assertion_error_with_del_series created!

@marksie1988
Copy link
Collaborator

After some investigation, it looks like sonarr responds with an empty dict {} to a delete where as others return a 200 ok

Will try re-work the assertions for this and get an update out shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants