Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: format homepage desc to code #1377

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

sungh0lim
Copy link
Contributor

Overview

  • Add codeblock(<code>) to homepage description.

AS-IS

스크린샷 2024-11-27 오전 10 10 33

TO-BE

스크린샷 2024-11-27 오전 10 10 46

PR Checklist

  • I did below actions if need
  1. I read the Contributing Guide
  2. I added documents and tests.

@sungh0lim sungh0lim requested a review from manudeli as a code owner November 27, 2024 01:23
Copy link

coauthors bot commented Nov 27, 2024

People can be co-author:

Candidate Reasons Count Add this as commit message
@sungh0lim #1377 1 Co-authored-by: sungh0lim <[email protected]>
@codecov-commenter #1377 (comment) 1 Co-authored-by: codecov-commenter <[email protected]>
@manudeli #1377 (review) 1 Co-authored-by: manudeli <[email protected]>

Copy link

changeset-bot bot commented Nov 27, 2024

⚠️ No Changeset found

Latest commit: 2f0d3be

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Nov 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
suspensive.org ❌ Failed (Inspect) Nov 27, 2024 2:49am
v1.suspensive.org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 27, 2024 2:49am
visualization.suspensive.org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 27, 2024 2:49am

Copy link

vercel bot commented Nov 27, 2024

Someone is attempting to deploy a commit to the Toss Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

codspeed-hq bot commented Nov 27, 2024

CodSpeed Performance Report

Merging #1377 will create unknown performance changes

Comparing sungh0lim:docs/format-homepage-desc-code (2f0d3be) with main (6662e3f)

Summary

⚠️ No benchmarks were detected in both the base of the PR and the PR.\

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.86%. Comparing base (6662e3f) to head (2f0d3be).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1377   +/-   ##
=======================================
  Coverage   73.86%   73.86%           
=======================================
  Files          69       69           
  Lines         593      593           
  Branches      134      134           
=======================================
  Hits          438      438           
  Misses        144      144           
  Partials       11       11           
Components Coverage Δ
@suspensive/react 100.00% <ø> (ø)
@suspensive/react-dom 95.55% <ø> (ø)
@suspensive/react-native 100.00% <ø> (ø)
@suspensive/react-query 82.67% <ø> (ø)
@suspensive/react-query-4 0.00% <ø> (ø)
@suspensive/react-query-5 0.00% <ø> (ø)
@suspensive/jotai 0.00% <ø> (ø)
@suspensive/codemods 41.97% <ø> (ø)

Copy link
Member

@manudeli manudeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍

@manudeli manudeli merged commit a1841c8 into toss:main Nov 28, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants