Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(suspensive.org): add docs for cli #1032
docs(suspensive.org): add docs for cli #1032
Changes from 1 commit
b3a8283
a88949b
3f5339f
129dcc0
86ec195
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to discuss this part. Since version 2.2.0, @suspensive/react-query has been internally switching between @suspensive/react-query-4 and @suspensive/react-query-5. To make it easier for users to understand, I have referred to this as “modules” in the document. I thought it would be confusing to call them versions 4 or 5 of @suspensive/react-query, as it might be mistaken for the actual package versions.
I think “modules” or “adapters” would be good terms. Do you have any better ideas?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@manudeli What do you think about this opinion? I'm concerned that calling
@suspensive/react-query-4
and@suspensive/react-query-5
"versions" in the documentation might cause confusion with the actual@suspensive/react-query
package versions. I think it would be better to refer to them as "modules" or "adapters."There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with you. Rather than entering the version number, I think it would be simpler to understand by expressing it as follows.
Automatically changes Suspensive’s interface according to the version of @tanstack/react-query.