Skip to content

Commit

Permalink
chore(.github/actions/pnpm-setup-node): remove version field in with …
Browse files Browse the repository at this point in the history
…of pnpm/action-setup (#1363)

# Overview

<!--
    A clear and concise description of what this pr is about.
 -->

removed the version specified in the with field of pnpm/action-setup.
[when the pnpm version is already defined in the packageManager field of
package.json, pnpm/action-setup can automatically recognize and use
it](https://github.com/pnpm/action-setup/tree/v4/?tab=readme-ov-file#version).
duplicating the version setting adds unnecessary complexity and
increases maintenance overhead without added benefit.

by relying on the version specified in packageManager, this change
simplifies the configuration and ensures consistency.

## PR Checklist

- [x] I did below actions if need

1. I read the [Contributing
Guide](https://github.com/toss/suspensive/blob/main/CONTRIBUTING.md)
2. I added documents and tests.
  • Loading branch information
sukvvon authored Nov 20, 2024
1 parent fbb937b commit 2d4e68f
Showing 1 changed file with 3 additions and 5 deletions.
8 changes: 3 additions & 5 deletions .github/actions/pnpm-setup-node/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,8 @@ runs:
using: composite
steps:
- uses: pnpm/action-setup@v4
with:
version: 9.12.3
- uses: actions/setup-node@v4
with:
cache: "pnpm"
cache-dependency-path: "pnpm-lock.yaml"
node-version-file: ".nvmrc"
cache: 'pnpm'
cache-dependency-path: 'pnpm-lock.yaml'
node-version-file: '.nvmrc'

0 comments on commit 2d4e68f

Please sign in to comment.