Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can not gain same values as in code. #22

Closed
VCasecnikovs opened this issue Dec 23, 2020 · 3 comments
Closed

Can not gain same values as in code. #22

VCasecnikovs opened this issue Dec 23, 2020 · 3 comments

Comments

@VCasecnikovs
Copy link

Good evening,
I have tried to train SAC on PACMAN 2 times with the default config file and also with the slightly changed config file.
I change the batch size to 2048 and use_per to True. Unfortunately, I didn't get a good policy.
Could You tell me where could be an error and how to solve it?
Maybe I chose bad params...

image

Best regards,
Vadims.

@toshikwa
Copy link
Owner

Maybe I chose bad params...

If you think so, why don't you try the default parameters to see what is wrong?

First of all, batch_size=2048 is too big.
Also, if you modified the code, I can't help you with debugging.

Here are the results of SAC-Discrete in MsPacmanNoFramsskep-v4 I ran today, and it learned well.

Default Config
スクリーンショット 2020-12-24 13 43 02

Default Config + use_per=True
スクリーンショット 2020-12-24 13 42 49

@VCasecnikovs
Copy link
Author

Good morning,
The red one is the default parameters.
I'll try to retest with default config again without any changes in code.
Thank you for saying that I should control BS, what is more interesting bigger BS gave me 1200 on the test.
Best regards,
Vadims.

@VCasecnikovs
Copy link
Author

Good evening,
I have tested with the default settings, all works!
Also, I have tested with my pull request. FloatTensor doesn't lower the performance. Results are the same, but these changes make code more universal.
image
Hope You will merge it,
Best regards,
Vadims.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants