Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exceptions in _validate() method of FormFields not being propogated #42

Open
atbinf opened this issue Jun 10, 2015 · 0 comments
Open

Exceptions in _validate() method of FormFields not being propogated #42

atbinf opened this issue Jun 10, 2015 · 0 comments

Comments

@atbinf
Copy link

atbinf commented Jun 10, 2015

I just noticed that all the FormFields that override _validate() do not have their ValidationErrors (if the occur) caught and propagated to the "invalid" widget for display in the form. Example Widgets were the CheckBoxList and CheckBoxTable. To fix this I had to place the @twc.validation.catch_errors decorator on top of them. I noticed that in "dynforms" and core, they seem to pretty consistently do this for these methods when they are overridden. Any comments on this? Is this a bug in "forms" or in how the exceptions are being caught and handled in "core".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants