Cannot download on Arch

[timkgh]

> uname -a
Linux arch 6.5.7-arch1-1 #1 SMP PREEMPT_DYNAMIC Tue, 10 Oct 2023 21:10:21 +0000 x86_64 GNU/Linux

> torbrowser-launcher 
Tor Browser Launcher
By Micah Lee, licensed under MIT
version 0.3.6
https://github.com/micahflee/torbrowser-launcher
Downloading Tor Browser for the first time.
Downloading https://aus1.torproject.org/torbrowser/update_3/release/Linux_x86_64-gcc3/x/ALL
Latest version: 13.0
Downloading https://dist.torproject.org/torbrowser/13.0/tor-browser-linux64-13.0_ALL.tar.xz.asc
Download Error: 404

That linux64 in the URL looks questionable, the file should be tor-browser-linux-x86_64-13.0.tar.xz.asc

[margual56]

That linux64 in the URL looks questionable, the file should be tor-browser-linux-x86_64-13.0.tar.xz.asc

Just for reference, the code to blame is

torbrowser-launcher/torbrowser_launcher/common.py

Line 107 in 4652b44

arch = "linux64"

---

The _ALL also looks like it shouldn't be there

torbrowser-launcher/torbrowser_launcher/common.py

Line 111 in 4652b44

tarball_filename = "tor-browser-" + arch + "-" + tbb_version + "_ALL.tar.xz"

[margual56]

As a temporary workaround to get it to work, you can just edit the file, in my computer found at /usr/lib/python3.11/site-packages/torbrowser_launcher/common.py

[jefernfos]

@margual56 Replacing the line 111
tarball_filename = "tor-browser-" + arch + "-" + tbb_version + "_ALL.tar.xz"
with
tarball_filename = "tor-browser-" + "linux-x86_64" + "-" + tbb_version + ".tar.xz
worked with the flatpak version. Thanks.

[TheFibonacciEffect]

Replacing the line worked for me as well, thank you very much

[boklm]

With version 13.0 Tor Browser changed its filenames. As a temporary workaround we added some redirects on the server to make the old filenames work.

[margual56]

Can confirm it works now :)

[lowusage]

The package in arch linux's extras (https://archlinux.org/packages/extra/any/torbrowser-launcher/) hasn't been updated, and the redirects doesn't seems to work anymore.

Changing the line as a temporary patch did the trick; but I marked the package as out-of-date today. Hope it'll get updated soon !

[boklm]

redirects should be working again now.

[lowusage]

I can confirm, the redirects works and I'm able to download the archive from the installer as of now.

[kpcyrd]

Considering Arch Linux is shipping the latest version 0.3.6, is there anything we should do at the moment? :) The relevant commit seems to be 1a0562b and isn't part of a release yet, but could be cherry-picked into the Arch Linux package.

[boklm]

Considering Arch Linux is shipping the [latest version](https://github.com/torproject/torbrowser-launcher/tags) 0.3.6, is there anything we should do at the moment? :)

Not yet, but we should tag a version 0.3.7 soon.

[kpcyrd]

I've also opened #717 to upgrade the build system from ./setup.py install to wheels.

[lowusage]

The extra's package has been updated.

It uses a patch for the download URL, and upgrade the BS to wheel.

This issue seems to be resolved.

[joshhilton]

The issue is still present on Debian bullseye

[lowusage]

The issue is still present on Debian bullseye

Since this issue is specific to a package release, I think this should go to a new issue.

Anyway, I don't see any related patch in bullseye or bullseye-backport repositories. They seems to uses the 0.3.3 release of this soft, which is out-of-date whatever.
This should be addressed to the packagers.

More generally, the issue is present in every package repositories that don't include a patch, since no official release of this soft, including the related change, has been published.

[boklm]

More generally, the issue is present in every package repositories that don't include a patch, since no official release of this soft, including the related change, has been published.

Which issue exactly? Version 3.3.6 without patch is still using the old URL, but a redirect on the server should make it work.

[lowusage]

You're right !
I misinterpreted what could possibly go wrong.

Here, if the package has been installed from the debian bullseye contrib repo, we still get the 404.
See this output from a docker runnning debian bullseye (with XServer on the host):

Tor Browser Launcher
By Micah Lee, licensed under MIT
version 0.3.3
https://github.com/micahflee/torbrowser-launcher
Downloading Tor Browser for the first time.
Downloading https://aus1.torproject.org/torbrowser/update_3/release/Linux_x86_64-gcc3/x/en-US
Latest version: 13.0.5
Downloading https://dist.torproject.org/torbrowser/13.0.5/tor-browser-linux64-13.0.5_en-US.tar.xz.asc
Download Error: 404

The error comes from common.py:157,159 in torbrowser-launcher 0.3.3:

tarball_filename = (
    "tor-browser-" + arch + "-" + tbb_version + "_" + language + ".tar.xz"
)

Since this package is out-of-date, it doesn't follow the '_ALL' language directive found in 0.3.6, this could cause the redirect to not work.

(in any case it is related, but this is an exceptional case where the provided package is out-of-date)
EDIT: this means that it should be reported to package maintainers, and they should upgrade to a more recent version.