Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverse some deprecation warnings from Tornado 6.2 #3216

Closed
bdarnell opened this issue Jan 17, 2023 · 2 comments
Closed

Reverse some deprecation warnings from Tornado 6.2 #3216

bdarnell opened this issue Jan 17, 2023 · 2 comments

Comments

@bdarnell
Copy link
Member

Key portions of the asyncio deprecation changes begun in Python 3.10 have been reversed. As a result, many of the deprecations made in Tornado 6.2 are no longer necessary. (with the additional caveat that Python versions 3.10.0--3.10.8 and 3.11.0 may still raise deprecation warnings under the old rules. 3.10.9 or 3.11.1 are needed to avoid the warnings)

Specifically, I believe we can un-deprecate the make_current/clear_current methods, the IOLoop constructor, and AsyncTestCase. AnyThreadEventLoopPolicy is still deprecated. The bind/start multi-process pattern no longer encounters deprecation errors from asyncio, but we want to keep it deprecated for other reasons (#2801).

It's also no longer necessary to update all docs to use the asyncio.run pattern, although I think we still want to start nudging people in this direction. These interfaces should still be discouraged in the docs even though we're no longer actively planning to disable and remove them. (with the possible exception of AsyncHTTPTestCase - we don't yet have a counterpart based on unittest.IsolatedAsyncioTestCase).

@bdarnell
Copy link
Member Author

The most recent cpython changes related to this have not yet been released; I think we need to wait until 3.12a5 (due Feb 6) to work on this.

@bdarnell
Copy link
Member Author

bdarnell commented Apr 8, 2023

These changes were made in #3223. The final decision was to undeprecate AsyncTestCase, AsyncHTTPTestCase, and the IOLoop constructor. make_current/clear_current remain deprecated, and so do AnyThreadEventLoopPolicy and bind/start.

@bdarnell bdarnell closed this as completed Apr 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant