Fix deprecation error messages on PHP 8.1 #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Was just about to make a PR for this myself. Getting lots of warnings in my terminal:
Would be great to have this merged. Thanks @bakerkretzmar! |
|
Thank you @bakerkretzmar! I was wondering why this was an issue for Jigsaw, but it looks like Jigsaw runs on Laravel 8 now! I'll need to do some extra testing to make sure it all still works with y'alls latest stuff. |
|
Thanks! Yeah we're finally only one year behind 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing
nullto some of these arguments is deprecated in PHP 8.1 which logs out a bunch of clutter in the terminal while building.