Upgrade to http-proxy-middleware v3

torchbox · Dec 16, 2024 · 283ce81 · 283ce81
1 parent 93a870e
commit 283ce81
Show file tree

Hide file tree

Showing 4 changed files with 93 additions and 113 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,6 +4,10 @@
 
 ## Unreleased
 
+### Changed
+
+- Upgrade to http-proxy-middleware v3
+
 ## [[v1.0.0]](https://github.com/torchbox/storybook-django/releases/tag/v1.0.0) (2024-07-27)
 
 ### Added

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -33,7 +33,7 @@
     "nunjucks"
   ],
   "dependencies": {
-    "http-proxy-middleware": "^2.0.0"
+    "http-proxy-middleware": "^3.0.0"
   },
   "peerDependencies": {
     "react": "^16.8.0  || ^17.0.0 || ^18.0.0"

diff --git a/src/middleware.js b/src/middleware.js
@@ -1,15 +1,5 @@
 const { createProxyMiddleware } = require('http-proxy-middleware');
 
-// https://github.com/chimurai/http-proxy-middleware/issues/40#issuecomment-249430255
-const restream = (proxyReq, req) => {
-  if (req.body) {
-    const bodyData = JSON.stringify(req.body);
-    proxyReq.setHeader('Content-Type', 'application/json');
-    proxyReq.setHeader('Content-Length', Buffer.byteLength(bodyData));
-    proxyReq.write(bodyData);
-  }
-};
-
 /**
  * Initialises a http-proxy-middleware for Storybook to talk to Django without CORS issues.
  * @param {object} options options
@@ -24,9 +14,8 @@ const createDjangoAPIMiddleware = (options) => {
     router.use(
       apiPath,
       createProxy({
-        target: origin,
+        target: `${origin}${apiPath}`,
         changeOrigin: true,
-        onProxyReq: restream,
       }),
     );
   };