Fix matrix multiplication #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dilorfin
requested changes
Jun 23, 2021
Comment on lines
120
to
148
| private static unsafe double[,] MulMatrixTest(double[,] left, double[,] right) | ||
| { | ||
| var m = left.GetLength(0); | ||
| var n = right.GetLength(1); | ||
| var K = left.GetLength(1); | ||
| var len1 = left.Length; | ||
| var matrix = new double[m, n]; | ||
|
|
||
| fixed (double* pointer1 = left) | ||
| fixed (double* pointer2 = right) | ||
| fixed (double* pointer3 = matrix) | ||
| { | ||
| var span1 = new Span<double>(pointer1, len1); | ||
|
|
||
| for (var i = 0; i < m; i++) | ||
| { | ||
| var c = pointer3 + i * n; | ||
|
|
||
| for (var k = 0; k < K; k++) | ||
| { | ||
| var b = pointer2 + k * n; | ||
| var a = span1[i * K + k]; | ||
| for (var j = 0; j < n; j++) c[j] += a * b[j]; | ||
| } | ||
| } | ||
|
|
||
| return matrix; | ||
| } | ||
| } |
There was a problem hiding this comment.
What a f is here we have?)
Are you sure that we should use "unsafe code" is Unit Tests?
Obviously, I don't think so! As for me code in unit tests must be as simple&stupid as it only can be
There was a problem hiding this comment.
it is ctrl C + Ctrl V for testing:)
There was a problem hiding this comment.
but in the end it doesn't even matter, copying code for unit tests from tested code...
Comment on lines
102
to
111
| var matrixB = new double[size, size]; | ||
| for (int i = 0; i < matrixB.GetLength(0); i++) | ||
| { | ||
| for (int j = 0; j < matrixB.GetLength(1); j++) | ||
| { | ||
| matrixB[i, j] = 1; | ||
| } | ||
| } | ||
|
|
||
| var expected = MulMatrixTest(matrixB, matrixB); |
There was a problem hiding this comment.
Multiplication result for square matrixes that consist only of 1 will be just matrix sizexsize that consist of size
Dilorfin
approved these changes
Jun 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.