Skip to content
This repository has been archived by the owner on Feb 26, 2019. It is now read-only.

Pick up vendored dep versions if possible #477

Open
freeformz opened this issue May 23, 2016 · 2 comments
Open

Pick up vendored dep versions if possible #477

freeformz opened this issue May 23, 2016 · 2 comments

Comments

@freeformz
Copy link

freeformz commented May 23, 2016

Reported here: kubernetes/node-problem-detector#7

@freeformz
Copy link
Author

This is because github.com/hpcloud/tail vendors a a version of gopkg.in/fsnotify.v1 that doesn't import golang.org/x/sys/unix. But godep flattens vendor folders and pulls up the dependency, so that there is only a single top level vendor directory. This required a version of gopkg.in/fsnotify.v1 be installed in the $GOPATH. The version vendored in hpcloud/tail is "7be54206639f256967dd82fa767397ba5f8f48f5" (1.2.1), while the version vendored in node-problem-detector is "30411dbcefb7a1da7e84f75530ad3abe4011b4f8".

@freeformz
Copy link
Author

At some point godep should start taking a look at the versions of vendored deps and throwing an error if they (a) conflict or (b) what it would copy would be different.

@freeformz freeformz changed the title Have to run godep save twice to get dep Pick up vendored dep versions if possible May 24, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant