-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect output in Safari #6
Comments
Yes, this is puzzling. Any ideas? I've seen the same for js-nacl. I wrote the following in the js-nacl readme - perhaps it should be transplanted to the js-scrypt readme, too? If you can contribute more information about exactly which versions of Safari work (or fail to work), that'd be greatly appreciated. (N.B. enabling/disabling Javascript debugging seems to affect the fault, or at least it does for me!)
|
Although I haven't had a chance to look at the code in detail yet, my intuition would be that it's a problem with format conversions (? byte to hex, flip endian) or some other low-level string formatting stuff that Javascript doesn't handle elegantly, and which could be implemented inconsistently. |
This issue is occurring on iOS as well, as expected. Users on Subrosa are unable to sign in across Safari (including iOS) or non-Safari devices. |
@ixro there is in the wild a js re-write of C code that goes into scrypt. It is written so that you may indicate with a progress bar how far you are in the progress, which is a very useful feature in UI. |
Any updates on this? In chrome on desktop this lib seems to be only a little bit faster than scrypt-async-js.
Thinking of using js-scrypt as a performance improvement for phones that support it. |
The tests pass on Safari/601.6.17. I don't have access to iOS variants or older versions anymore; do any others in the thread still experience problems? (N.B. I just recompiled js-scrypt with a new emscripten the other day, and moved to scrypt 1.2.0.) |
The tests fail in Safari:
The text was updated successfully, but these errors were encountered: