Modified all chicken gifs to have the same canvas size #622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
now whenver an animation is triggered, the chicken won't magically change size
tonybaloney
approved these changes
Nov 30, 2024
|
Thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Idea from #604
I noticed when petting the chicken it's size went all over the place. With each gif now having the same canvas size, the chicken now keeps it relative size. Since the horse gives extra canvas size for animations I think it only made sense that the chicken does too, making the pet's animations more homogenized.
I understand this doesn't add the suggested solution to programmatically size different pets, but if that were to happen in the future, I think this would be a necessary bridge to cross.
Before:
After: