-
-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add snail pet #577
Add snail pet #577
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please can you rename the GIFs so that they are all lower case. If you're using Windows you need to use the git mv
command.
This is a great PR, please can you look at my comments. Also please add an attribution for the artwork to README along with the others. |
Ah the snails are named incorrectly. The file names should match the
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #577 +/- ##
==========================================
+ Coverage 16.58% 17.06% +0.47%
==========================================
Files 23 25 +2
Lines 1236 1260 +24
Branches 167 167
==========================================
+ Hits 205 215 +10
- Misses 1025 1039 +14
Partials 6 6 ☔ View full report in Codecov by Sentry. |
I had rename the gif files as requested. @tonybaloney |
Hi there, I want to contribute to this repo by adding a new feature (pet snail). This is my first open-source PR, let me know if there is any problem, perhaps some guidance would be nice too. :)