Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add snail pet #577

Merged
merged 13 commits into from
Jun 17, 2024
Merged

Add snail pet #577

merged 13 commits into from
Jun 17, 2024

Conversation

WoofWoof0
Copy link
Contributor

Hi there, I want to contribute to this repo by adding a new feature (pet snail). This is my first open-source PR, let me know if there is any problem, perhaps some guidance would be nice too. :)

Copy link
Owner

@tonybaloney tonybaloney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please can you rename the GIFs so that they are all lower case. If you're using Windows you need to use the git mv command.

@tonybaloney
Copy link
Owner

This is a great PR, please can you look at my comments. Also please add an attribution for the artwork to README along with the others.

@WoofWoof0 WoofWoof0 requested a review from tonybaloney June 12, 2024 07:51
@tonybaloney
Copy link
Owner

Ah the snails are named incorrectly.

The file names should match the npm run test:gifs output

File "./media/snail/brown_idle_8fps.gif" does not exist.
File "./media/snail/brown_run_8fps.gif" does not exist.
File "./media/snail/brown_swipe_8fps.gif" does not exist.
File "./media/snail/brown_walk_8fps.gif" does not exist.
File "./media/snail/brown_walk_fast_8fps.gif" does not exist.
File "./media/snail/brown_with_ball_8fps.gif" does not exist.

@codecov-commenter
Copy link

codecov-commenter commented Jun 12, 2024

Codecov Report

Attention: Patch coverage is 38.46154% with 8 lines in your changes missing coverage. Please review.

Project coverage is 17.06%. Comparing base (61374a6) to head (441977d).
Report is 28 commits behind head on main.

Files Patch % Lines
src/panel/pets/snail.ts 50.00% 4 Missing ⚠️
src/extension/extension.ts 0.00% 2 Missing ⚠️
src/panel/pets.ts 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #577      +/-   ##
==========================================
+ Coverage   16.58%   17.06%   +0.47%     
==========================================
  Files          23       25       +2     
  Lines        1236     1260      +24     
  Branches      167      167              
==========================================
+ Hits          205      215      +10     
- Misses       1025     1039      +14     
  Partials        6        6              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@WoofWoof0
Copy link
Contributor Author

WoofWoof0 commented Jun 14, 2024

I had rename the gif files as requested. @tonybaloney

@tonybaloney tonybaloney merged commit a48fb66 into tonybaloney:main Jun 17, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants