Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: add DbOption supports setting the s3 FsOptions of all sstables #239

Open
KKould opened this issue Nov 25, 2024 · 2 comments
Open
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@KKould
Copy link
Contributor

KKould commented Nov 25, 2024

What is the current?

Currently, tonbo needs to be able to set each level's sstables to be stored in different S3 configurations, but there is no option to set all sstables in the same S3 configuration at once.In many cases we only need to set it up in the same S3 configuration

options = options
                // TODO: We can add an option user to set all SSTables to use the same URL.
                .level_path(0, url.clone(), fs_option.clone())
                .unwrap()
                .level_path(1, url.clone(), fs_option.clone())
                .unwrap()
                .level_path(2, url.clone(), fs_option.clone())
                .unwrap()
                .level_path(3, url.clone(), fs_option.clone())
                .unwrap()
                .level_path(4, url.clone(), fs_option.clone())
                .unwrap()
                .level_path(5, url.clone(), fs_option.clone())
                .unwrap()
                .level_path(6, url, fs_option.clone())
                .unwrap();

What will it become?

options = options
                .all_level_path(url.clone(), fs_option.clone())
                .unwrap()

What are the benefits?

simple

Are there any alternatives?

maybe

Does it have a reference?

nope

@KKould KKould added enhancement New feature or request good first issue Good for newcomers labels Nov 25, 2024
Copy link

linear bot commented Nov 25, 2024

@ethe

This comment was marked as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants