Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: define record::runtime::Column with ColumnDesc #238

Open
ethe opened this issue Nov 24, 2024 · 1 comment
Open

refactor: define record::runtime::Column with ColumnDesc #238

ethe opened this issue Nov 24, 2024 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers XS - Tiny Fixing typos, adding or modifying comments, minor configuration changes.

Comments

@ethe
Copy link
Member

ethe commented Nov 24, 2024

What is the current?

Column define as:

pub struct Column {
    pub datatype: Datatype,
    pub value: Arc<dyn Any + Send + Sync>,
    pub is_nullable: bool,
    pub name: String,
}

and ColumnDesc define as:

pub struct ColumnDesc {
    pub datatype: Datatype,
    pub is_nullable: bool,
    pub name: String,
}

which is redundant

What will it become?

Define Column like:

pub struct Column {
    pub desc: ColumnDesc,
    pub value: Arc<dyn Any + Send + Sync>,
}

should be great.

What are the benefits?

Make definition clearer

Are there any alternatives?

No

Does it have a reference?

I think there might be a lot, I will add it in the future.

@ethe ethe added the enhancement New feature or request label Nov 24, 2024
Copy link

linear bot commented Nov 24, 2024

@ethe ethe added good first issue Good for newcomers XS - Tiny Fixing typos, adding or modifying comments, minor configuration changes. labels Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers XS - Tiny Fixing typos, adding or modifying comments, minor configuration changes.
Projects
None yet
Development

No branches or pull requests

1 participant