Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FuturePut fails with churn and low peer numbers #99

Open
tbocek opened this issue Apr 13, 2015 · 1 comment
Open

FuturePut fails with churn and low peer numbers #99

tbocek opened this issue Apr 13, 2015 · 1 comment

Comments

@tbocek
Copy link
Member

tbocek commented Apr 13, 2015

I observed a case where I get after a DHT put request a success = false, but the storage succeeded (could load it later from another peer).
failedReason is: Future (compl/canc):true/false, FAILED, Expected 3 result, but got 2
That happened after I shut down one peer, so it seems that the client expects 3 peers but gets returned only 2 at the future result and therefore reports success=false.

@tbocek
Copy link
Member Author

tbocek commented Apr 13, 2015

The number of peers for requests in small networks is based on the local neighbor map. If I have 3 neighbors, I can get at most 3 answers, if now one goes offline and the local neighbor map is not updated yet, then the future will fail.

I think a proper way to deal with this is to get the number of neighbors from the routing itself and not from the neighbor map. However, this only happens for small networks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant