fix: use local binaries, nicer error messages

Author: tommy-mitchell

.github/workflows/test-pr.yml

@@ -9,7 +9,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        node-version: [16, 18]
+        node-version: [16, 18, 20]
     steps:
       - uses: actions/checkout@v3
       - uses: actions/setup-node@v3

.github/workflows/test-push.yml

@@ -11,7 +11,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        node-version: [16, 18]
+        node-version: [16, 18, 20]
     steps:
       - uses: actions/checkout@v3
       - uses: actions/setup-node@v3

package.json

@@ -34,9 +34,11 @@
 	],
 	"scripts": {
 		"prepare": "npm run build",
-		"build": "tsc -p tsconfig.build.json && execify --pkg --fix-shebang",
+		"build": "tsc -p tsconfig.build.json && execify --all",
 		"lint": "xo",
-		"test": "listr 'tsc --noEmit' 'c8 ava'"
+		"test": "tsc --noEmit && npm run ava",
+		"ava": "node -e 'if (process.version.startsWith(`v20`)) process.exit(1)' && ava || npm run ava:20",
+		"ava:20": "cross-env NODE_OPTIONS='--loader=ts-node/esm --loader=esmock --no-warnings=ExperimentalWarning' ava"
 	},
 	"ava": {
 		"files": [
@@ -55,8 +57,9 @@
 		]
 	},
 	"dependencies": {
-		"execa": "^7.2.0",
-		"get-bin-path": "^10.0.0"
+		"execa": "^8.0.1",
+		"get-bin-path": "^10.0.0",
+		"log-symbols": "^5.1.0"
 	},
 	"devDependencies": {
 		"@shopify/semaphore": "^3.0.2",
@@ -65,14 +68,14 @@
 		"ava": "^5.3.1",
 		"c8": "^8.0.1",
 		"cross-env": "^7.0.3",
-		"esmock": "^2.3.6",
-		"execify-cli": "^0.1.0",
+		"esmock": "^2.3.8",
+		"execify-cli": "beta",
 		"is-executable": "^2.0.1",
-		"listr-cli": "^0.3.0",
 		"meow": "^11.0.0",
+		"strip-ansi": "^7.1.0",
 		"testtriple": "^2.2.3",
 		"ts-node": "^10.9.1",
 		"typescript": "~5.1.6",
-		"xo": "^0.54.2"
+		"xo": "^0.56.0"
 	}
 }

readme.md

@@ -141,9 +141,8 @@ The syntax for mapping to a source binary can be verbose. Adding the following a
 alias bin-path-map="bin-path dist.js:::src.ts"
 ```
 
-#### Notice
-
-The feature is under-tested and the syntax is subject to change. If you have any problems or suggestings, please [file an issue](https://github.com/tommy-mitchell/bin-path-cli/issues/new).
+> [!NOTE]
+> The feature is under-tested and the syntax is subject to change. If you have any problems or suggestings, please [file an issue](https://github.com/tommy-mitchell/bin-path-cli/issues/new).
 
 ## Related
 

src/cli.ts

@@ -1,6 +1,6 @@
 #!/usr/bin/env ts-node-esm
 import process from "node:process";
-import { execaCommand, type ExecaError } from "execa";
+import { execa, type ExecaError } from "execa";
 import { exit, tryGetBinPath, tryMapBinPath } from "./helpers.js";
 
 // First two arguments are Node binary and this binary
@@ -24,7 +24,7 @@ if (shouldMap) {
 }
 
 try {
-	await execaCommand(`${binPath!}${" " + args.join(" ")}`, { stdio: "inherit" });
+	await execa(binPath!, args, { preferLocal: true, stdio: "inherit" });
 } catch (error: unknown) {
 	const potentialError = error as ExecaError | undefined;
 

src/helpers.ts

@@ -1,5 +1,6 @@
 import process from "node:process";
 import { getBinPath } from "get-bin-path";
+import logSymbols from "log-symbols";
 import type { Match } from "./types.js";
 
 type ExitArgs = {
@@ -10,7 +11,7 @@ type ExitArgs = {
 /** Exit with an optional error message. */
 export const exit = ({ message, exitCode = 1 }: ExitArgs = {}): never => {
 	if (message) {
-		console.error(message);
+		console.error(`${logSymbols.error} ${message}`);
 	}
 
 	process.exit(exitCode);

test/cli.ts

@@ -99,7 +99,7 @@ test("no bin", verifyCli, {
 	fixture: "no-bin",
 	expectations: {
 		exitCode: 1,
-		stderr: `No binary found. ${helpText}`,
+		stderr: `✖ No binary found. ${helpText}`,
 	},
 });
 
@@ -145,7 +145,7 @@ test("named binary - no default - errors", verifyCli, {
 	fixture: "named-binaries/no-default",
 	expectations: {
 		exitCode: 1,
-		stderr: `No binary found. ${helpText}`,
+		stderr: `✖ No binary found. ${helpText}`,
 	},
 });
 
@@ -169,15 +169,15 @@ test("handles incorrect execute permissions", verifyCli, {
 	fixture: "bad-permissions",
 	expectations: {
 		exitCode: 1,
-		stderr: "The binary could not be executed. Does it have the right permissions?",
+		stderr: "✖ The binary could not be executed. Does it have the right permissions?",
 	},
 });
 
 test("missing binary", verifyCli, {
 	fixture: "missing-binary",
 	expectations: {
 		exitCode: 1,
-		stderr: "The binary does not exist. Does it need to be built?",
+		stderr: "✖ The binary does not exist. Does it need to be built?",
 	},
 });
 

test/exit.ts

@@ -1,5 +1,6 @@
 import test from "ava";
 import esmock from "esmock";
+import stripAnsi from "strip-ansi";
 
 type MacroArgs = [{
 	exitCode?: number;
@@ -22,7 +23,7 @@ const verifyHelper = test.macro<MacroArgs>(async (t, { exitCode = 1, message = "
 		},
 		import: {
 			console: {
-				error: (errorMessage: string) => verify(errorMessage, message, "message"),
+				error: (errorMessage: string) => verify(stripAnsi(errorMessage), `✖ ${message}`, "message"),
 			},
 		},
 	}) as typeof import("../src/helpers.js");