Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Array::push and others explicitly apply default formatting, rather than implicitly. #826

Open
epage opened this issue Jan 20, 2025 · 0 comments
Labels
A-edit Area: TOML editing API C-bug Category: Things not working as expected M-breaking-change Meta: Implementing or merging this will introduce a breaking change.

Comments

@epage
Copy link
Member

epage commented Jan 20, 2025

Found via rust-lang/cargo#15084 where a &str was pushed into an Array and then sort_by_keyed. This made it so the formatting applied by push was not relevant. If we delay until we render, then we'll know how to handle this.

The default formatting was added in #88. I think after that we added the tracking of "this is in a default state" and wouldn't need this anymore.

@epage epage added A-edit Area: TOML editing API C-bug Category: Things not working as expected M-breaking-change Meta: Implementing or merging this will introduce a breaking change. labels Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-edit Area: TOML editing API C-bug Category: Things not working as expected M-breaking-change Meta: Implementing or merging this will introduce a breaking change.
Projects
None yet
Development

No branches or pull requests

1 participant