LocalPath no longer lowercases it's paths on win32 #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates LocalPath to not call str.lower() on paths that are passed in to it. The base Path class calls str.lower() before doing any comparisons already so it seems like this was a bit redundant. Also updated Path.__hash__ to call str.lower on the path before hashing when on windows so that behaviour in dictionaries etc. is consistent.
|
thanks! i'll look into it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the fix I've been using locally for #38. I'm not sure if it's correct, so feel free to reject the pull request if I've messed up somehow.
I've updated LocalPath to not call str.lower() on paths that are passed in to it. The base Path class calls str.lower() before doing any comparisons already so it seems like this was a bit redundant.
Also updated Path.hash to call str.lower on the path before hashing when on windows so that behaviour in dictionaries etc. is consistent.