Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handles "prevent duplicates" issue #56

Closed

Conversation

RangarajKaushikSundar
Copy link
Collaborator

The code for some reason doesn't seem to accept the "preventDuplicates" value, even if its passed in the toastr options. The updated code always sets preventDuplicates to true.

Functionality:
When there is a toastr message, there will be no duplicate toastr messages called until the toastr message closes.

The code for some reason doesn't seem to accept the "preventDuplicates" value, even if its passed in the toastr options. The updated code always sets preventDuplicates to true. 

Functionality:
When there is a toastr message, there will be no duplicate toastr messages called until the toastr message closes.
@tomchentw
Copy link
Owner

@RangarajKaushikSundar Thanks for the work. Could you apply these changes to files under src/ only? lib/ should be automatically generated from the release process.

RangarajKaushikSundar added a commit to RangarajKaushikSundar/react-toastr that referenced this pull request Jun 13, 2016
Same as: Handles "prevent duplicates" issue tomchentw#56
Changes made to src rather than lib
@RangarajKaushikSundar
Copy link
Collaborator Author

@tomchentw
Thank you for your time. The changes have been made in a new pull request

@RangarajKaushikSundar RangarajKaushikSundar deleted the patch-1 branch June 13, 2016 18:54
tomchentw pushed a commit that referenced this pull request Jun 14, 2016
* Thanks to @RangarajKaushikSundar 
* Original commit: 00817d9
* Original commit: 87e38e4
* Closes #58 
* Closes #56 
* Closes #53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants