Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version 2.6.0 introduces a breaking change #49

Closed
JamieDixon opened this issue Apr 28, 2016 · 4 comments
Closed

Version 2.6.0 introduces a breaking change #49

JamieDixon opened this issue Apr 28, 2016 · 4 comments

Comments

@JamieDixon
Copy link

JamieDixon commented Apr 28, 2016 •
edited
Loading

Since the 2.6.0 release, React 15 is required.

This broke our codebase because 2.6.0 introduces a breaking change and our match for "^2.4.0" allowed for 2.6.0 to be installed without warning.

Since 2.6.0 introduces this breaking change I suggest the version be bumped to the next major version, 3.0 in line with semver.

What do you think? Thanks for react-toastr, we really appreciate all your work on this library!
@JamieDixon JamieDixon changed the title Upgrading to 2.6.0 introduces a breaking change Version 2.6.0 introduces a breaking change Apr 28, 2016
@jerairrest
Copy link
Contributor

I agree!

@tomchentw
Copy link
Owner

Apologies for that. I didn't review carefully when merging PR #48. How about change it to:

    "react": "^0.14.0 || ^15.0.0",
    "react-dom": "^0.14.0 || ^15.0.0"

@tomchentw
Copy link
Owner

@JamieDixon
Copy link
Author

Thanks Tom. Much appreciated. Be well.

@tomchentw tomchentw mentioned this issue May 10, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tomchentw @JamieDixon @jerairrest