Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animation lag #6

Open
paurbo opened this issue Oct 19, 2020 · 5 comments
Open

Animation lag #6

paurbo opened this issue Oct 19, 2020 · 5 comments

Comments

@paurbo
Copy link

paurbo commented Oct 19, 2020

I’m on an iPhone XR, iOS 13.5. The animation lags at first but ends smooth. Here is a video of it.

@tomaszpoliszuk
Copy link
Owner

tomaszpoliszuk commented Oct 19, 2020

If by lag you mean that moment when splash part (white background circle) seems to kind of pause for a moment and then proceed to expand and eventually fade off then it is byproduct of using Ease In Ease Out in splash element and i've decide to leave it for a moment like it is now (IDK it by accident automatically brings water splash to my memory) but it will most likely cease to exist in next phase of development when i will upgrade animation to better reflect one made by Apple in iOS 14.1

@paurbo
Copy link
Author

paurbo commented Oct 20, 2020

Yeah it seems to pause twice I think. I was just comparing it to the video on the tweak page in which it seems quite a lot more smooth. I guess that one is the native one. Apart from the pauses they are very similar - great job!

@tomaszpoliszuk
Copy link
Owner

No - that video is from custom animation i"ve made - just to be 100% sure - could you try to disable other tweaks and test how this animation looks then (but I'm 95% sure this is correct - at least after comparing code and video - behavior).

@IORose
Copy link

IORose commented May 19, 2021

I’m on an iPhone XR, iOS 13.5. The animation lags at first but ends smooth. Here is a video of it.

I have the same issue:
iPhone 11
iOS 13.5
unc0ver 5.3.1

https://youtu.be/GPtRlFuCD3E

@tomaszpoliszuk
Copy link
Owner

It was intentional at time of writing this animation but yeah - it looks different than original MagSafe animation and seems like it's lagging.
I'm in process of rewriting whole custom part (ideally to have identical animation as it's in iOS 14.1 and up) so changes are coming but it's hard to say when it will happen.

I'll keep this issue open until i publish updated version of this animation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants