Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

limit decorator compatible with asyncio #26

Open
evemorgen opened this issue Oct 29, 2018 · 4 comments
Open

limit decorator compatible with asyncio #26

evemorgen opened this issue Oct 29, 2018 · 4 comments

Comments

@evemorgen
Copy link

Hi,
I find this module very useful and promising - however more and more of my code is getting asyncio based. Wouldn't it be nice if limit decorator could be asyncio compliant?

It seems like aio-limit would be essentially the same as limit with couple of async and await in it.
I'm willing to make a PR for that. Would you guys consider merging such thing?

@evemorgen evemorgen changed the title limit decorator compatible with asyncio limit decorator compatible with asyncio Oct 29, 2018
@x4v13r64
Copy link

Any progress on this?

@evemorgen
Copy link
Author

evemorgen commented Aug 15, 2019

@j4v thanks for pinging me on this one. I've made a PR for this #35 - please have a look 😃
However, I'm not sure whether it's going to be merged (and when if so) due to not being python 2.7 compatible. I'd love to hear maintainers opinion about it!

@x4v13r64
Copy link

Thanks @evemorgen - looks good. We've implemented this (for now) with https://github.com/hallazzang/asyncio-throttle and it works, but as the library isn't supported we'd rather move to a more mature project as https://github.com/tomasbasham/ratelimit.

@stuaxo
Copy link

stuaxo commented Feb 21, 2020

@tomasbasham would it be possible to merge this, now that python 2.7 is unsupported ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants