Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Last generated token getting ignored in streaming.py? #45

Open
ritik99 opened this issue Mar 29, 2024 · 0 comments
Open

Last generated token getting ignored in streaming.py? #45

ritik99 opened this issue Mar 29, 2024 · 0 comments

Comments

@ritik99
Copy link

ritik99 commented Mar 29, 2024

Hello,

I was looking into the streaming.py code and noticed that in greedy_generate() we overwrite what the previous input_ids was on line 33. According to my understanding of the code, this will replace whatever token is last generated and assigned to input_ids on line 42. Essentially the last generated token for every prompt is never considered as a Query token.

I don't think it will lead to any significant change in the model outputs, but just wanted to confirm if my understanding is correct.

Thanks for sharing this implementation btw!

Ritik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant