Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@Retained and @Arg in Fragment inheritance #18

Open
ykostova opened this issue Jan 12, 2016 · 2 comments
Open

@Retained and @Arg in Fragment inheritance #18

ykostova opened this issue Jan 12, 2016 · 2 comments
Labels

Comments

@ykostova
Copy link

If a fragment A has @ Retained fields and it is extended by a fragment B with both @ Retained and @ Arg fields, the latter's (B's) builder cannot be compiled because a Builder cannot be found for the parent (A).

This situation can be easily recreated by letting ArgRetainedFragment extend BaseRetainedFragment from the provided sample.

The problem can be resolved by introducing false @ Arg fields in the parent (A) fragment but it is my understand that this is not part of the intended behaviour.

PS: Amazing library ! Thanks for all your hard work.

@ykostova ykostova changed the title @Retain and @Arg in Fragment inheritance @Retained and @Arg in Fragment inheritance Jan 12, 2016
@tom91136 tom91136 added the bug label Jan 12, 2016
@tom91136
Copy link
Owner

Confirmed.
I'm currently doing a full rewrite of the library since it's getting very messy, see #17 for background. I'll make sure to add specific test cases for this in the rewrite. Please leave this issue open so I can close it via commit once the rewrite is done.

PS:Sorry if you need this fixed urgently, but the rewrite will take a while as I'm having exams in Uni.

@ykostova
Copy link
Author

Thanks very much for that. I am excited to see the new version. And again thanks for your effort :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants