Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace atty #2724

Open
dvdplm opened this issue Sep 22, 2023 · 3 comments
Open

Replace atty #2724

dvdplm opened this issue Sep 22, 2023 · 3 comments

Comments

@dvdplm
Copy link
Contributor

dvdplm commented Sep 22, 2023

Feature Request

Crates

tracing-log

Motivation

tracing-log depends on a version of env_logger that is affected by GHSA-g98v-hv3f-hcfr by way of its dependency on atty (currently unmaintained).

Proposal

Upgrade the env_logger dependency and make a patch release.
@dvdplm dvdplm mentioned this issue Sep 22, 2023
Closed
@hawkw
Copy link
Member

hawkw commented Sep 25, 2023

It looks like you closed the PR that fixes this?

@dvdplm
Copy link
Contributor Author

dvdplm commented Sep 26, 2023

@hawkw I'm not sure how to make a PR against a tag (tracing-log-0.1.3 in this case) so I accidentally opened a PR against main (which I closed).

The fix is so minimal (env_logger = { version = "0.10", optional = true }) that I didn't bother to figure out how it's done...

@kaffarell
Copy link
Contributor

We can close this PR as this has been fixed with commit 4161d81 (in pr #2772).
Though it still needs to be ported to master :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dvdplm @hawkw @kaffarell