Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release notes is missing feature: tracing-subscriber 0.3.16 #2582

Closed
ozgunozerk opened this issue May 8, 2023 · 3 comments
Closed

Release notes is missing feature: tracing-subscriber 0.3.16 #2582

ozgunozerk opened this issue May 8, 2023 · 3 comments

Comments

@ozgunozerk
Copy link
Contributor

ozgunozerk commented May 8, 2023

Bug Report

For this release: https://github.com/tokio-rs/tracing/releases/tag/tracing-subscriber-0.3.16
I think the feature of keeping max N files with this PR: #2323
is missed.

I just noticed this, because:
I was using v0.1.x branch in my cargo.toml, and it's been 8 months, so I've decided to check the release notes once more. After couldn't see the new feature in the release notes, I've decided to check commits, and then found out that with subscriber-0.3.16, this feature seems to be in the code for the commit used for this release. However, there are no mention of this feature, nor the contributors in the release notes.

@ozgunozerk
Copy link
Contributor Author

I probably confused myself. When I browse the files of commit that is used for 0.3.16 via GitHub UI, the changes of max_n_files are there in appender.
However, in the source-code in my project, they are not there.
Don't know how to interpret this 🤷

@hawkw
Copy link
Member

hawkw commented May 8, 2023

tracing-appender and tracing-subscriber are separate crates. The tracing-subscriber 0.3.16 release will not contain features added to tracing-appender.

We need to release a new version of tracing-appender before this change will become available.

@ozgunozerk
Copy link
Contributor Author

Thank you for the clarification!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants