Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cancellation safety of tokio::process::Child::wait #5976

Closed
AndWass opened this issue Sep 3, 2023 · 1 comment · Fixed by #5977
Closed

Cancellation safety of tokio::process::Child::wait #5976

AndWass opened this issue Sep 3, 2023 · 1 comment · Fixed by #5977
Labels
A-tokio Area: The main tokio crate C-bug Category: This is a bug. E-help-wanted Call for participation: Help is requested to fix this issue. M-process Module: tokio/process T-docs Topic: documentation

Comments

@AndWass
Copy link

AndWass commented Sep 3, 2023

The documentation lacks information regarding cancellation safety of tokio::process::Child::wait
@Darksonn Darksonn added T-docs Topic: documentation A-tokio Area: The main tokio crate M-process Module: tokio/process C-bug Category: This is a bug. E-help-wanted Call for participation: Help is requested to fix this issue. labels Sep 3, 2023
@Darksonn
Copy link
Contributor

Darksonn commented Sep 3, 2023

The method is cancel safe. It just needs to be added to the documentation.

@maminrayej maminrayej mentioned this issue Sep 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-tokio Area: The main tokio crate C-bug Category: This is a bug. E-help-wanted Call for participation: Help is requested to fix this issue. M-process Module: tokio/process T-docs Topic: documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add cancel-safety documentation for child::wait maminrayej/tokio
2 participants
@Darksonn @AndWass