Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tokio-stream] Implement From<Receiver> for ReceiverStream (and maybe others) #4015

Closed
ShadowJonathan opened this issue Aug 2, 2021 · 1 comment · Fixed by #4080
Closed

[tokio-stream] Implement From<Receiver> for ReceiverStream (and maybe others) #4015

ShadowJonathan opened this issue Aug 2, 2021 · 1 comment · Fixed by #4080
Labels
A-tokio-stream Area: The tokio-stream crate C-feature-request Category: A feature request.

Comments

@ShadowJonathan
Copy link

Reading this doc page, it occurred to me that this needs to be constructed explicitly, wouldn't it be possible to make easier by implementing a From<Receiver> trait?

This probably also counts for other tokio_stream::wrappers::* structs, if they haven't already gotten these impls.
@ShadowJonathan ShadowJonathan added A-tokio Area: The main tokio crate C-feature-request Category: A feature request. labels Aug 2, 2021
@Darksonn Darksonn added A-tokio-stream Area: The tokio-stream crate and removed A-tokio Area: The main tokio crate labels Aug 2, 2021
@Darksonn
Copy link
Contributor

Darksonn commented Aug 2, 2021

I am fine with adding such From impls.

@FrancisMurillo FrancisMurillo mentioned this issue Aug 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-tokio-stream Area: The tokio-stream crate C-feature-request Category: A feature request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add From<Receiver<T>> impl for receiver streams FrancisMurillo/tokio
2 participants
@Darksonn @ShadowJonathan