Skip to content

Commit 128f411

Browse files
NobodyXutaiki-e
andcommitted
Simplify cfg for import of wasm_bindgen_test::wasm_bindgen_test
Co-authored-by: Taiki Endo <[email protected]> Signed-off-by: Jiahao XU <[email protected]>
1 parent 4be9109 commit 128f411

File tree

4 files changed

+32
-48
lines changed

4 files changed

+32
-48
lines changed

tokio/src/runtime/coop.rs

+3-7
Original file line numberDiff line numberDiff line change
@@ -246,18 +246,14 @@ cfg_coop! {
246246
mod test {
247247
use super::*;
248248

249-
cfg_is_wasm_not_wasi! {
250-
use wasm_bindgen_test::wasm_bindgen_test as test;
251-
}
252-
253-
#[cfg(not(all(target_family = "wasm", not(target_os = "wasi"))))]
254-
use std::prelude::v1::test;
249+
#[cfg(all(target_family = "wasm", not(target_os = "wasi")))]
250+
use wasm_bindgen_test::wasm_bindgen_test as test;
255251

256252
fn get() -> Budget {
257253
context::budget(|cell| cell.get()).unwrap_or(Budget::unconstrained())
258254
}
259255

260-
#[self::test]
256+
#[test]
261257
fn budgeting() {
262258
use futures::future::poll_fn;
263259
use tokio_test::*;

tokio/src/sync/tests/atomic_waker.rs

+5-9
Original file line numberDiff line numberDiff line change
@@ -12,14 +12,10 @@ impl AssertSync for AtomicWaker {}
1212
impl AssertSend for Waker {}
1313
impl AssertSync for Waker {}
1414

15-
cfg_is_wasm_not_wasi! {
16-
use wasm_bindgen_test::wasm_bindgen_test as test;
17-
}
18-
19-
#[cfg(not(all(target_family = "wasm", not(target_os = "wasi"))))]
20-
use std::prelude::v1::test;
15+
#[cfg(all(target_family = "wasm", not(target_os = "wasi")))]
16+
use wasm_bindgen_test::wasm_bindgen_test as test;
2117

22-
#[self::test]
18+
#[test]
2319
fn basic_usage() {
2420
let mut waker = task::spawn(AtomicWaker::new());
2521

@@ -29,7 +25,7 @@ fn basic_usage() {
2925
assert!(waker.is_woken());
3026
}
3127

32-
#[self::test]
28+
#[test]
3329
fn wake_without_register() {
3430
let mut waker = task::spawn(AtomicWaker::new());
3531
waker.wake();
@@ -40,7 +36,7 @@ fn wake_without_register() {
4036
assert!(!waker.is_woken());
4137
}
4238

43-
#[self::test]
39+
#[test]
4440
#[cfg(not(target_family = "wasm"))] // wasm currently doesn't support unwinding
4541
fn atomic_waker_panic_safe() {
4642
use std::panic;

tokio/src/sync/tests/notify.rs

+6-10
Original file line numberDiff line numberDiff line change
@@ -3,14 +3,10 @@ use std::future::Future;
33
use std::sync::Arc;
44
use std::task::{Context, RawWaker, RawWakerVTable, Waker};
55

6-
cfg_is_wasm_not_wasi! {
7-
use wasm_bindgen_test::wasm_bindgen_test as test;
8-
}
9-
10-
#[cfg(not(all(target_family = "wasm", not(target_os = "wasi"))))]
11-
use std::prelude::v1::test;
6+
#[cfg(all(target_family = "wasm", not(target_os = "wasi")))]
7+
use wasm_bindgen_test::wasm_bindgen_test as test;
128

13-
#[self::test]
9+
#[test]
1410
fn notify_clones_waker_before_lock() {
1511
const VTABLE: &RawWakerVTable = &RawWakerVTable::new(clone_w, wake, wake_by_ref, drop_w);
1612

@@ -50,7 +46,7 @@ fn notify_clones_waker_before_lock() {
5046
}
5147

5248
#[cfg(panic = "unwind")]
53-
#[self::test]
49+
#[test]
5450
fn notify_waiters_handles_panicking_waker() {
5551
use futures::task::ArcWake;
5652

@@ -88,7 +84,7 @@ fn notify_waiters_handles_panicking_waker() {
8884
}
8985
}
9086

91-
#[self::test]
87+
#[test]
9288
fn notify_simple() {
9389
let notify = Notify::new();
9490

@@ -104,7 +100,7 @@ fn notify_simple() {
104100
assert!(fut2.poll().is_ready());
105101
}
106102

107-
#[self::test]
103+
#[test]
108104
#[cfg(not(target_family = "wasm"))]
109105
fn watch_test() {
110106
let rt = crate::runtime::Builder::new_current_thread()

tokio/src/sync/tests/semaphore_batch.rs

+18-22
Original file line numberDiff line numberDiff line change
@@ -3,14 +3,10 @@ use tokio_test::*;
33

44
const MAX_PERMITS: usize = crate::sync::Semaphore::MAX_PERMITS;
55

6-
cfg_is_wasm_not_wasi! {
7-
use wasm_bindgen_test::wasm_bindgen_test as test;
8-
}
9-
10-
#[cfg(not(all(target_family = "wasm", not(target_os = "wasi"))))]
11-
use std::prelude::v1::test;
6+
#[cfg(all(target_family = "wasm", not(target_os = "wasi")))]
7+
use wasm_bindgen_test::wasm_bindgen_test as test;
128

13-
#[self::test]
9+
#[test]
1410
fn poll_acquire_one_available() {
1511
let s = Semaphore::new(100);
1612
assert_eq!(s.available_permits(), 100);
@@ -20,7 +16,7 @@ fn poll_acquire_one_available() {
2016
assert_eq!(s.available_permits(), 99);
2117
}
2218

23-
#[self::test]
19+
#[test]
2420
fn poll_acquire_many_available() {
2521
let s = Semaphore::new(100);
2622
assert_eq!(s.available_permits(), 100);
@@ -33,7 +29,7 @@ fn poll_acquire_many_available() {
3329
assert_eq!(s.available_permits(), 90);
3430
}
3531

36-
#[self::test]
32+
#[test]
3733
fn try_acquire_one_available() {
3834
let s = Semaphore::new(100);
3935
assert_eq!(s.available_permits(), 100);
@@ -45,7 +41,7 @@ fn try_acquire_one_available() {
4541
assert_eq!(s.available_permits(), 98);
4642
}
4743

48-
#[self::test]
44+
#[test]
4945
fn try_acquire_many_available() {
5046
let s = Semaphore::new(100);
5147
assert_eq!(s.available_permits(), 100);
@@ -57,7 +53,7 @@ fn try_acquire_many_available() {
5753
assert_eq!(s.available_permits(), 90);
5854
}
5955

60-
#[self::test]
56+
#[test]
6157
fn poll_acquire_one_unavailable() {
6258
let s = Semaphore::new(1);
6359

@@ -81,7 +77,7 @@ fn poll_acquire_one_unavailable() {
8177
assert_eq!(s.available_permits(), 1);
8278
}
8379

84-
#[self::test]
80+
#[test]
8581
fn poll_acquire_many_unavailable() {
8682
let s = Semaphore::new(5);
8783

@@ -118,7 +114,7 @@ fn poll_acquire_many_unavailable() {
118114
assert_ready_ok!(acquire_3.poll());
119115
}
120116

121-
#[self::test]
117+
#[test]
122118
fn try_acquire_one_unavailable() {
123119
let s = Semaphore::new(1);
124120

@@ -137,7 +133,7 @@ fn try_acquire_one_unavailable() {
137133
assert_eq!(s.available_permits(), 1);
138134
}
139135

140-
#[self::test]
136+
#[test]
141137
fn try_acquire_many_unavailable() {
142138
let s = Semaphore::new(5);
143139

@@ -159,7 +155,7 @@ fn try_acquire_many_unavailable() {
159155
assert_eq!(s.available_permits(), 2);
160156
}
161157

162-
#[self::test]
158+
#[test]
163159
fn poll_acquire_one_zero_permits() {
164160
let s = Semaphore::new(0);
165161
assert_eq!(s.available_permits(), 0);
@@ -174,19 +170,19 @@ fn poll_acquire_one_zero_permits() {
174170
assert_ready_ok!(acquire.poll());
175171
}
176172

177-
#[self::test]
173+
#[test]
178174
fn max_permits_doesnt_panic() {
179175
Semaphore::new(MAX_PERMITS);
180176
}
181177

182-
#[self::test]
178+
#[test]
183179
#[should_panic]
184180
#[cfg(not(target_family = "wasm"))] // wasm currently doesn't support unwinding
185181
fn validates_max_permits() {
186182
Semaphore::new(MAX_PERMITS + 1);
187183
}
188184

189-
#[self::test]
185+
#[test]
190186
fn close_semaphore_prevents_acquire() {
191187
let s = Semaphore::new(5);
192188
s.close();
@@ -200,7 +196,7 @@ fn close_semaphore_prevents_acquire() {
200196
assert_eq!(5, s.available_permits());
201197
}
202198

203-
#[self::test]
199+
#[test]
204200
fn close_semaphore_notifies_permit1() {
205201
let s = Semaphore::new(0);
206202
let mut acquire = task::spawn(s.acquire(1));
@@ -213,7 +209,7 @@ fn close_semaphore_notifies_permit1() {
213209
assert_ready_err!(acquire.poll());
214210
}
215211

216-
#[self::test]
212+
#[test]
217213
fn close_semaphore_notifies_permit2() {
218214
let s = Semaphore::new(2);
219215

@@ -247,7 +243,7 @@ fn close_semaphore_notifies_permit2() {
247243
assert_eq!(2, s.available_permits());
248244
}
249245

250-
#[self::test]
246+
#[test]
251247
fn cancel_acquire_releases_permits() {
252248
let s = Semaphore::new(10);
253249
s.try_acquire(4).expect("uncontended try_acquire succeeds");
@@ -263,7 +259,7 @@ fn cancel_acquire_releases_permits() {
263259
assert_ok!(s.try_acquire(6));
264260
}
265261

266-
#[self::test]
262+
#[test]
267263
fn release_permits_at_drop() {
268264
use crate::sync::semaphore::*;
269265
use futures::task::ArcWake;

0 commit comments

Comments
 (0)