Skip to content
This repository has been archived by the owner on Sep 13, 2018. It is now read-only.

All errors are forcibly thrown in the trash #176

Open
sfackler opened this issue Jul 4, 2017 · 0 comments
Open

All errors are forcibly thrown in the trash #176

sfackler opened this issue Jul 4, 2017 · 0 comments

Comments

@sfackler
Copy link

sfackler commented Jul 4, 2017

The various ServerProto traits can all return errors, but those errors are thrown away (e.g. here). It is really important for debugability to be able to have some nonzero amount of information about what's happening when your requests aren't getting through.

You can write a wrapping proto that intercepts the errors and e.g. logs them but it is over 100 lines of code for a single "kind" of proto, and regardless, silently throwing away errors is not a reasonable default. Here's one example of confusion caused by this: sfackler/rust-postgres#260

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant