Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.0: Style creation can become stuck if theme only has references and no active token sets #2896

Closed
six7 opened this issue Jun 21, 2024 · 0 comments · Fixed by #2954
Closed
Assignees
Labels
bug Something isn't working plugin v2 variables, UI, WTCG format, Bitbucket

Comments

@six7
Copy link
Collaborator

six7 commented Jun 21, 2024

When creating styles we end up in a endless loading state when sets used in the themes are not active but disabled or reference only.

To reproduce:

  • Create new file
  • Create a token
  • Create a theme group called Theme / Default or anything
  • Set the token set to disabled or reference only
  • Proceed to create styles (it's enough to leave one of the styles checkboxes active)

Expected: Do not get stuck on style creation
Actual: Style creation spinner goes on forever

Bonus: Can we adjust the error message if the reason for it was not that no themes were active but that inside there weren't any sets active? No styles created. Make sure some sets are active

Image

@six7 six7 added bug Something isn't working plugin v2 variables, UI, WTCG format, Bitbucket labels Jun 21, 2024
@six7 six7 moved this to 📤 Ready for dev in Tokens Studio for Figma Roadmap Jun 21, 2024
@akshay-gupta7 akshay-gupta7 self-assigned this Jun 25, 2024
@akshay-gupta7 akshay-gupta7 moved this from 📤 Ready for dev to 🕜 In Progress in Tokens Studio for Figma Roadmap Jun 26, 2024
@six7 six7 closed this as completed Jul 5, 2024
@github-project-automation github-project-automation bot moved this from 🕜 In Progress to ✅ Done in Tokens Studio for Figma Roadmap Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working plugin v2 variables, UI, WTCG format, Bitbucket
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

2 participants