Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should no :focus outline when :active #179

Closed
zcyzcy88 opened this issue Mar 27, 2017 · 7 comments · Fixed by #181
Closed

Should no :focus outline when :active #179

zcyzcy88 opened this issue Mar 27, 2017 · 7 comments · Fixed by #181

Comments

@zcyzcy88
Copy link

zcyzcy88 commented Mar 27, 2017

Note:
Browser add focus and active status when you ~~~mouseup~~~ mousedown a element


Now

https://todc.github.io/todc-bootstrap/css/#buttons-options
2017-03-27 19_40_41-css todc bootstrap


Expect

https://translate.google.com
2017-03-27 19_41_32-google translate

@acmetech
Copy link
Collaborator

Hi @zcyzcy88,

What version(s) of what browser(s) are you seeing this in?

Thanks

@zcyzcy88
Copy link
Author

All.

Click and hold a colored button.
The outline should not appear when holding.

@acmetech
Copy link
Collaborator

@zcyzcy88,

I understand, but what browser(s)/version(s) are you seeing this in?

Thanks

@zcyzcy88
Copy link
Author

Windows 10 desktop:

  • IE 11
  • Chrome 59 (Canary)
  • Firefox 52

@acmetech
Copy link
Collaborator

I am unable to replicate this with Firefox 52.0.1 on a Mac at https://translate.google.com. However, I can replicate it with Firefox 52.0.1 at Gmail. I can also replicate it using Chrome 57.0.2987.110 at https://translate.google.com.

Thanks

@zcyzcy88 zcyzcy88 changed the title No :focus outline when :active Should no :focus outline when :active Mar 28, 2017
@zcyzcy88
Copy link
Author

This issue is a visual improvement, I think outline should not cover inner shadow.

Thanks for your continue fixing.

@acmetech
Copy link
Collaborator

You're welcome

acmetech added a commit that referenced this issue Mar 29, 2017
Add blue border on .btn-link:focus, and fix "Proper fix #179"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants