Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[.btn:not(.btn-link)] sholud never have Webkit's default outline #176

Closed
zcyzcy88 opened this issue Mar 22, 2017 · 2 comments
Closed

[.btn:not(.btn-link)] sholud never have Webkit's default outline #176

zcyzcy88 opened this issue Mar 22, 2017 · 2 comments

Comments

@zcyzcy88
Copy link

zcyzcy88 commented Mar 22, 2017

https://todc.github.io/todc-bootstrap/css#buttons-options

Chrome (may any browser)

  1. Click and hold a .btn.btn-default button
  2. Look the outline
2017-03-22 19_06_03-css todc bootstrap

or

  1. Click a .btn:not(.btn-default):not(.btn-link) button
  2. Look the outline
2017-03-22 18_47_16-css todc bootstrap
@zcyzcy88 zcyzcy88 changed the title [.btn] sholud never have Webkit's default outline [.btn:not(.btn-link)] sholud never have Webkit's default outline Mar 22, 2017
@acmetech
Copy link
Collaborator

Hi @zcyzcy88,

Does this issue also occur in Bootstrap 3 and/or 4 or is it specific to todc-bootstrap?

Thanks

@zcyzcy88
Copy link
Author

zcyzcy88 commented Mar 22, 2017

TWBS 3:

  • Don't implement its own outline style
  • Don't remove Webkit's default outline

2017-03-22 21_42_41-css bootstrap


TWBS 4:

  • Implemented its own outline style
  • Removed Webkit's default outline

2017-03-22 21_45_24-buttons bootstrap


TODC

  • Implemented its own outline style
  • Not completely removed Webkit's default outline

https://github.com/todc/todc-bootstrap/blob/master/less/buttons.less#L58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants