Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 20: Remove raw SQL usage from the codebase #24

Merged
merged 2 commits into from
Jul 9, 2020
Merged

Issue 20: Remove raw SQL usage from the codebase #24

merged 2 commits into from
Jul 9, 2020

Conversation

tobyash86
Copy link
Owner

Merging same orders in the cart by increasing quantity instead of duplicating them

@tobyash86
Issue 20: Remove raw SQL usage from the codebase
10705eb 
Merging same orders in the cart by increasing quantity instead of duplicating them
@tobyash86 tobyash86 requested review from jzielnik, ma-rybak and pkrukp and removed request for pkrukp and ma-rybak July 9, 2020 13:18
@tobyash86 tobyash86 linked an issue Jul 9, 2020 that may be closed by this pull request
Duplicate entries in cart causes exception during checkout #23
Closed
@tobyash86 tobyash86 added this to the webgoat.net-1.0 milestone Jul 9, 2020
@tobyash86 tobyash86 added the bug Something isn't working label Jul 9, 2020
@tobyash86 tobyash86 self-assigned this Jul 9, 2020
jzielnik
jzielnik previously requested changes Jul 9, 2020
View reviewed changes
WebGoatCore/Controllers/CartController.cs Outdated Show resolved Hide resolved
@tobyash86 tobyash86 dismissed jzielnik’s stale review July 9, 2020 15:08

Issue fixed without re-review request from reviewer side.

@tobyash86 tobyash86 merged commit 2ff6f38 into dev Jul 9, 2020
@tobyash86 tobyash86 deleted the issue-20-Remove_raw_SQL_usage_from_the_codebase branch July 9, 2020 15:10
@tobyash86 tobyash86 linked an issue Nov 17, 2020 that may be closed by this pull request
Remove raw SQL usage from the codebase #20
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jzielnik jzielnik jzielnik left review comments

Assignees

@tobyash86 tobyash86

Labels
bug Something isn't working
Projects
None yet
Milestone
webgoat.net-0.1
Development

Successfully merging this pull request may close these issues.

Remove raw SQL usage from the codebase Duplicate entries in cart causes exception during checkout
2 participants
@tobyash86 @jzielnik