Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gulp imgres.buildAtlas not throw if java not installed #1565

Open
ArtemNikolaev opened this issue Sep 6, 2023 · 3 comments
Open

Gulp imgres.buildAtlas not throw if java not installed #1565

ArtemNikolaev opened this issue Sep 6, 2023 · 3 comments

Comments

@ArtemNikolaev
Copy link

There's a minor issue with gulp builder on task imgres.buildAtlas

image

in case to check java availability code running comand "java -version".
Issue is that no error will be shown if java not installed.

So, the good idea to add more clear check of java version, which will show error when you trying to do this task without java installed.

@EmeraldBlock
Copy link
Collaborator

child_process.execSync will throw if there is an error though, as written at https://nodejs.org/api/child_process.html#child_processexecsynccommand-options

or were you running this yourself and it didn't error for you? If so, could you send logs?

@ArtemNikolaev
Copy link
Author

@EmeraldBlock
I think java -version don't thow any error:
image
As you can see, no changes in colors or something, just info about which packages can be installed

@EmeraldBlock
Copy link
Collaborator

@ArtemNikolaev
oh sorry, I meant non-zero exit code (which you can display by running echo $?, I think)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants