Skip to content
This repository has been archived by the owner on Dec 5, 2024. It is now read-only.

performance #18

Closed
andreineculau opened this issue May 19, 2019 · 0 comments · Fixed by #20
Closed

performance #18

andreineculau opened this issue May 19, 2019 · 0 comments · Fixed by #20

Comments

@andreineculau
Copy link
Contributor

andreineculau commented May 19, 2019

out of curiousity I just ran the basic benchmarking available at https://github.com/pinojs/pino npm run bench-basic

BASIC benchmark averages
Bunyan average: 680.751ms
Winston average: 496.127ms
Bole average: 375.836ms
Debug average: 328.526ms
LogLevel average: 328.303ms
MinLog average: 474.515ms
Pino average: 240.441ms
PinoExtreme average: 103.965ms
PinoNodeStream average: 219.996ms

I identified some red flags, that when/if removed takes minlog to:

BASIC benchmark averages
Bunyan average: 707.045ms
Winston average: 1885.363ms
Bole average: 627.995ms
Debug average: 416.026ms
LogLevel average: 452.593ms
MinLog average: 196.916ms
Pino average: 287.970ms
PinoExtreme average: 131.185ms
PinoNodeStream average: 283.553ms

red flags:

  • new Date() --- could consider Date.now()
  • getCallerInfo --- could be optional
  • rawEntry --- cloneDeep is expensive, could be optional
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant