Skip to content

Commit e02833d

Browse files
committed
Update tests fixtures to use a 'DOM' section instead of a 'dom' one top match more closely what's used in Prototype and thus help identify some template rendering issues.
1 parent 1d8292b commit e02833d

File tree

5 files changed

+71
-30
lines changed

5 files changed

+71
-30
lines changed

test/fixtures/ajax.js

+4-4
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11

22

33
/**
4-
* == dom ==
4+
* == DOM ==
55
* The DOM section
66
**/
77

@@ -20,7 +20,7 @@
2020
**/
2121

2222

23-
/** section: dom
23+
/** section: DOM
2424
* class Element
2525
* The Element class
2626
**/
@@ -32,7 +32,7 @@
3232
* the $ function
3333
**/
3434

35-
/** section: dom
35+
/** section: DOM
3636
* $$(selector) -> Array
3737
* the $$ function
3838
**/
@@ -527,7 +527,7 @@ Ajax.PeriodicalUpdater = Klass.create(Ajax.Base, {
527527
});
528528

529529

530-
/** deprecated, section: dom
530+
/** deprecated, section: DOM
531531
* Toggle
532532
**/
533533

test/fixtures/prototype.js

+6-6
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ if (Prototype.Browser.MobileSafari)
5151
**/
5252

5353
/**
54-
* == dom ==
54+
* == DOM ==
5555
* DOM extensions.
5656
**/
5757

@@ -2062,7 +2062,7 @@ Ajax.PeriodicalUpdater = Class.create(Ajax.Base, {
20622062
this.updater = new Ajax.Updater(this.container, this.url, this.options);
20632063
}
20642064
});
2065-
/** section: dom
2065+
/** section: DOM
20662066
* $(element) -> Element
20672067
* $(element...) -> [Element...]
20682068
* - element (Element | String): A reference to an existing DOM node _or_ a
@@ -2098,7 +2098,7 @@ if (Prototype.BrowserFeatures.XPath) {
20982098

20992099
/*--------------------------------------------------------------------------*/
21002100

2101-
/** section: dom
2101+
/** section: DOM
21022102
* Node
21032103
**/
21042104
if (!window.Node) var Node = { };
@@ -2121,7 +2121,7 @@ if (!Node.ELEMENT_NODE) {
21212121
});
21222122
}
21232123

2124-
/** section: dom
2124+
/** section: DOM
21252125
* class Element
21262126
**/
21272127
(function() {
@@ -3559,7 +3559,7 @@ Element.addMethods = function(methods) {
35593559
if (Element.extend.refresh) Element.extend.refresh();
35603560
Element.cache = { };
35613561
};
3562-
/** section: dom
3562+
/** section: DOM
35633563
* class Element.Layout
35643564
**/
35653565
Element.Layout = Class.create({
@@ -4106,7 +4106,7 @@ Object.extend(Element.Methods, {
41064106
}
41074107
});
41084108

4109-
/** section: dom
4109+
/** section: DOM
41104110
* document.viewport
41114111
**/
41124112

test/unit/parser/documentation_test.rb

+59-18
Original file line numberDiff line numberDiff line change
@@ -36,10 +36,10 @@ def test_mixins
3636
end
3737

3838
def test_sections
39-
assert_equal %w[ajax dom lang], fixtures.sections.map(&:name)
39+
assert_equal %w[DOM ajax lang], fixtures.sections.map(&:name)
4040
assert_equal [Section, Section, Section], fixtures.sections.map(&:class)
41-
assert_equal %w[Ajax], fixtures.sections.first.children.map(&:name)
42-
assert_equal %w[Ajax Base Manager Request Responders], fixtures.sections.first.descendants.map(&:name)
41+
assert_equal %w[Ajax], fixtures.sections[1].children.map(&:name)
42+
assert_equal %w[Ajax Base Manager Request Responders], fixtures.sections[1].descendants.map(&:name)
4343
end
4444

4545
def test_find_by_name
@@ -172,8 +172,8 @@ def test_klass
172172
assert_equal %w[bar foo], fixture.instance_methods.map(&:name)
173173
assert_equal [], fixture.instance_properties
174174
assert_equal %w[$], fixture.related_utilities.map(&:name)
175-
assert_equal "dom", fixture.doc_parent.name
176-
assert_equal %w[dom], fixture.ancestors.map(&:name)
175+
assert_equal "DOM", fixture.doc_parent.name
176+
assert_equal %w[DOM], fixture.ancestors.map(&:name)
177177
assert_equal [], fixture.children
178178
assert_equal [], fixture.descendants
179179

@@ -245,19 +245,19 @@ def test_utilities
245245
assert_equal "", fixture.namespace_string
246246
assert_equal "$", fixture.full_name
247247
assert_equal nil, fixture.klass_name
248-
assert_equal "dom", fixture.section.name
248+
assert_equal "DOM", fixture.section.name
249249
assert_equal fixtures.find_by_name("Element"), fixture.related_to
250250
assert_equal nil, fixture.namespace
251251
assert !fixture.deprecated?
252252
assert !fixture.alias?
253-
assert_equal "dom", fixture.doc_parent.name
254-
assert_equal %w[dom], fixture.ancestors.map(&:name)
253+
assert_equal "DOM", fixture.doc_parent.name
254+
assert_equal %w[DOM], fixture.ancestors.map(&:name)
255255
assert_equal [], fixture.children
256256
assert_equal [], fixture.descendants
257257

258258
fixture = fixtures.find_by_name("$$")
259259
assert_equal Utility, fixture.class
260-
assert_equal "dom", fixture.section.name
260+
assert_equal "DOM", fixture.section.name
261261
assert_equal nil, fixture.related_to
262262
end
263263

@@ -348,14 +348,14 @@ def test_instance_method
348348
assert_equal "Element", fixture.klass_name
349349
assert_equal Klass, fixture.klass.class
350350
assert_equal "Element", fixture.klass.full_name
351-
assert_equal "dom", fixture.section.name
351+
assert_equal "DOM", fixture.section.name
352352
assert_equal Klass, fixture.namespace.class
353353
assert_equal "Element", fixture.namespace.full_name
354354
assert !fixture.deprecated?
355355
assert !fixture.alias?
356356
assert fixture.methodized?
357357
assert_equal "Element", fixture.doc_parent.name
358-
assert_equal %w[Element dom], fixture.ancestors.map(&:name)
358+
assert_equal %w[Element DOM], fixture.ancestors.map(&:name)
359359
assert_equal [], fixture.children
360360
assert_equal [], fixture.descendants
361361
end
@@ -388,7 +388,7 @@ def test_deprecated
388388
assert_equal [], fixture.mixins
389389
assert_equal "Toggle", fixture.name
390390
assert_equal nil, fixture.klass
391-
assert_equal "dom", fixture.section.name
391+
assert_equal "DOM", fixture.section.name
392392
assert_equal "", fixture.namespace_string
393393
assert_equal nil, fixture.namespace
394394
assert fixture.deprecated?
@@ -398,8 +398,8 @@ def test_deprecated
398398
assert_equal [], fixture.instance_methods
399399
assert_equal [], fixture.instance_properties
400400
assert_equal [], fixture.related_utilities
401-
assert_equal "dom", fixture.doc_parent.name
402-
assert_equal %w[dom], fixture.ancestors.map(&:name)
401+
assert_equal "DOM", fixture.doc_parent.name
402+
assert_equal %w[DOM], fixture.ancestors.map(&:name)
403403
assert_equal %w[], fixture.children.map(&:name)
404404
assert_equal %w[], fixture.descendants.map(&:name)
405405

@@ -409,13 +409,13 @@ def test_deprecated
409409
assert_equal "Toggle", fixture.namespace_string
410410
assert_equal "Toggle.display", fixture.full_name
411411
assert_equal nil, fixture.klass_name
412-
assert_equal "dom", fixture.section.name
412+
assert_equal "DOM", fixture.section.name
413413
assert_equal Namespace, fixture.namespace.class
414414
assert_equal "Toggle", fixture.namespace.full_name
415415
assert fixture.deprecated?
416416
assert !fixture.alias?
417417
assert_equal "Toggle", fixture.doc_parent.name
418-
assert_equal %w[Toggle dom], fixture.ancestors.map(&:name)
418+
assert_equal %w[Toggle DOM], fixture.ancestors.map(&:name)
419419
assert_equal [], fixture.children
420420
assert_equal [], fixture.descendants
421421

@@ -425,13 +425,13 @@ def test_deprecated
425425
assert_equal "Toggle", fixture.namespace_string
426426
assert_equal "Toggle.foo", fixture.full_name
427427
assert_equal nil, fixture.klass_name
428-
assert_equal "dom", fixture.section.name
428+
assert_equal "DOM", fixture.section.name
429429
assert_equal Namespace, fixture.namespace.class
430430
assert_equal "Toggle", fixture.namespace.full_name
431431
assert fixture.deprecated?
432432
assert !fixture.alias?
433433
assert_equal "Toggle", fixture.doc_parent.name
434-
assert_equal %w[Toggle dom], fixture.ancestors.map(&:name)
434+
assert_equal %w[Toggle DOM], fixture.ancestors.map(&:name)
435435
assert_equal [], fixture.children
436436
assert_equal [], fixture.descendants
437437
end
@@ -476,4 +476,45 @@ def test_aliases
476476
assert fixture.alias?
477477
assert_equal "foo", fixture.alias_of.name
478478
end
479+
480+
def test_weird
481+
weird = parse(<<-EOS
482+
483+
/** section: DOM
484+
* document
485+
*
486+
* Prototype extends the built-in `document` object with several convenience
487+
* methods related to events.
488+
**/
489+
490+
491+
EOS
492+
)
493+
doc = weird.find_by_name("document")
494+
assert_equal 'document', doc.name
495+
assert_equal Documentation::Namespace, doc.class
496+
end
497+
498+
def test_weirder
499+
weird = parse(<<-EOS
500+
501+
/**
502+
* document.viewport
503+
*
504+
* The `document.viewport` namespace contains methods that return information
505+
* about the viewport &mdash; the rectangle that represents the portion of a web
506+
* page within view. In other words, it's the browser window minus all chrome.
507+
**/
508+
509+
510+
EOS
511+
)
512+
doc = weird.find_by_name("document.viewport")
513+
assert_equal 'viewport', doc.name
514+
assert_equal Documentation::Namespace, doc.class
515+
end
516+
517+
def test_weirdest
518+
519+
end
479520
end

website/html/documentation.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ <h2 id="tags">Tags</h2>
4343

4444
<p>Currently accepted tags are: <code>deprecated</code>, <code>section:</code>, <code>alias of:</code>, <code>related to:</code></p>
4545

46-
<pre><code>/** deprecated, section: dom, alias of: Element#descendantOf
46+
<pre><code>/** deprecated, section: DOM, alias of: Element#descendantOf
4747
* Element#childOf(@element, className) -&gt; Element
4848
* ...
4949
**/

website/markdown/syntax.markdown

+1-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ The first line of a comment is reserved for tags. Tags are optional. Tags are se
1717

1818
Currently accepted tags are: `deprecated`, `section:`, `alias of:`, `related to:`
1919

20-
/** deprecated, section: dom, alias of: Element#descendantOf
20+
/** deprecated, section: DOM, alias of: Element#descendantOf
2121
* Element#childOf(@element, className) -> Element
2222
* ...
2323
**/

0 commit comments

Comments
 (0)