Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hard to read comment changes in git diffs #19

Open
Doesntmeananything opened this issue May 11, 2021 · 0 comments
Open

Hard to read comment changes in git diffs #19

Doesntmeananything opened this issue May 11, 2021 · 0 comments

Comments

@Doesntmeananything
Copy link

Hi!

First of all, thank you very much for an awesome theme. I've gone through at least a hundred different themes for VSCode, and Raiju is the only one that I'm truly happy with.

I have found an issue where comments become hard to read when they are part of a git diff:

image

While the affected line on the left is readable, the one on the right is hard to visually parse due to low contrast between the text colour and the background, particularly for the part of the comment that's been newly inserted.

I was wondering if this is something you've previously considered?

As far as I know, there's no way to customise text color for certain syntax tokens displayed in the diff editor, so this doesn't look like something that's easily fixable. One way is to adjust the background color for inserted/deleted lines. It's also possible to adjust the text color for all comments and try to make them look nicer in the diff editor as well.

While I can definitely toy with these settings on my side, it'd be great to know if you have any thoughts on this, since I trust your aesthetic sensibilities much more than mine 😄 Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant