Factor out runScripts option tests

We will need to expand these substantially as part of fixing #1848 and #1828, so it'll be easier to keep them in another file.
jsdom · May 21, 2017 · 38c430f · 38c430f
1 parent ecf7449
commit 38c430f
Show file tree

Hide file tree

Showing 3 changed files with 76 additions and 68 deletions.
diff --git a/test/api/options-run-scripts.js b/test/api/options-run-scripts.js
@@ -0,0 +1,75 @@
+"use strict";
+const { assert } = require("chai");
+const { describe, it } = require("mocha-sugar-free");
+
+const { JSDOM } = require("../..");
+
+describe("API: runScripts constructor option", () => {
+  describe("<script>s and eval()", () => {
+    it("should not execute any scripts by default", () => {
+      const dom = new JSDOM(`<body>
+        <script>document.body.appendChild(document.createElement("hr"));</script>
+      </body>`);
+
+      assert.strictEqual(dom.window.document.body.children.length, 1);
+      assert.strictEqual(dom.window.eval, undefined);
+    });
+
+    it("should not execute any scripts, even in iframes, by default (GH-1821)", () => {
+      const dom = new JSDOM(`<iframe></iframe>`);
+      const frameWindow = dom.window.document.querySelector("iframe").contentWindow;
+
+      frameWindow.document.open();
+      frameWindow.document.write(`<script>parent.prop = "i was executed";</script>`);
+      frameWindow.document.close();
+
+      assert.strictEqual(dom.window.prop, undefined);
+      assert.strictEqual(frameWindow.eval, undefined);
+    });
+
+    it("should execute <script>s and eval when set to \"dangerously\"", () => {
+      const dom = new JSDOM(`<body>
+        <script>document.body.appendChild(document.createElement("hr"));</script>
+      </body>`, { runScripts: "dangerously" });
+      dom.window.eval(`document.body.appendChild(document.createElement("p"));`);
+
+      assert.strictEqual(dom.window.document.body.children.length, 3);
+    });
+
+    it("should only run eval when set to \"outside-only\"", () => {
+      const dom = new JSDOM(`<body>
+        <script>document.body.appendChild(document.createElement("hr"));</script>
+      </body>`, { runScripts: "outside-only" });
+      dom.window.eval(`document.body.appendChild(document.createElement("p"));`);
+
+      assert.strictEqual(dom.window.document.body.children.length, 2);
+    });
+
+    it("should ensure eval exists on iframes when set to \"outside-only\"", () => {
+      const dom = new JSDOM(`<iframe></iframe>`, { runScripts: "outside-only" });
+      const frameWindow = dom.window.document.querySelector("iframe").contentWindow;
+
+      frameWindow.eval(`document.body.appendChild(document.createElement("p"));`);
+
+      assert.strictEqual(frameWindow.document.body.children.length, 1);
+    });
+
+    it("should execute <script>s in iframes when set to \"dangerously\"", () => {
+      const dom = new JSDOM(`<iframe></iframe>`, { runScripts: "dangerously" });
+      const frameWindow = dom.window.document.querySelector("iframe").contentWindow;
+
+      frameWindow.document.open();
+      frameWindow.document.write(`<script>parent.prop = "i was executed";</script>`);
+      frameWindow.document.close();
+
+      assert.strictEqual(dom.window.prop, "i was executed");
+    });
+  });
+
+  it("should disallow other values", () => {
+    assert.throws(() => new JSDOM(``, { runScripts: null }), RangeError);
+    assert.throws(() => new JSDOM(``, { runScripts: "asdf" }), RangeError);
+    assert.throws(() => new JSDOM(``, { runScripts: true }), RangeError);
+    assert.throws(() => new JSDOM(``, { runScripts: false }), RangeError);
+  });
+});
diff --git a/test/api/options.js b/test/api/options.js
@@ -179,74 +179,6 @@ describe("API: constructor options", () => {
     });
   });
 
-  describe("runScripts", () => {
-    it("should not execute any scripts by default", () => {
-      const dom = new JSDOM(`<body>
-        <script>document.body.appendChild(document.createElement("hr"));</script>
-      </body>`);
-
-      assert.strictEqual(dom.window.document.body.children.length, 1);
-      assert.strictEqual(dom.window.eval, undefined);
-    });
-
-    it("should not execute any scripts, even in iframes, by default (GH-1821)", () => {
-      const dom = new JSDOM(`<iframe></iframe>`);
-      const frameWindow = dom.window.document.querySelector("iframe").contentWindow;
-
-      frameWindow.document.open();
-      frameWindow.document.write(`<script>parent.prop = "i was executed";</script>`);
-      frameWindow.document.close();
-
-      assert.strictEqual(dom.window.prop, undefined);
-      assert.strictEqual(frameWindow.eval, undefined);
-    });
-
-    it("should execute <script>s and eval when set to \"dangerously\"", () => {
-      const dom = new JSDOM(`<body>
-        <script>document.body.appendChild(document.createElement("hr"));</script>
-      </body>`, { runScripts: "dangerously" });
-      dom.window.eval(`document.body.appendChild(document.createElement("p"));`);
-
-      assert.strictEqual(dom.window.document.body.children.length, 3);
-    });
-
-    it("should only run eval when set to \"outside-only\"", () => {
-      const dom = new JSDOM(`<body>
-        <script>document.body.appendChild(document.createElement("hr"));</script>
-      </body>`, { runScripts: "outside-only" });
-      dom.window.eval(`document.body.appendChild(document.createElement("p"));`);
-
-      assert.strictEqual(dom.window.document.body.children.length, 2);
-    });
-
-    it("should ensure eval exists on iframes when set to \"outside-only\"", () => {
-      const dom = new JSDOM(`<iframe></iframe>`, { runScripts: "outside-only" });
-      const frameWindow = dom.window.document.querySelector("iframe").contentWindow;
-
-      frameWindow.eval(`document.body.appendChild(document.createElement("p"));`);
-
-      assert.strictEqual(frameWindow.document.body.children.length, 1);
-    });
-
-    it("should execute <script>s in iframes when set to \"dangerously\"", () => {
-      const dom = new JSDOM(`<iframe></iframe>`, { runScripts: "dangerously" });
-      const frameWindow = dom.window.document.querySelector("iframe").contentWindow;
-
-      frameWindow.document.open();
-      frameWindow.document.write(`<script>parent.prop = "i was executed";</script>`);
-      frameWindow.document.close();
-
-      assert.strictEqual(dom.window.prop, "i was executed");
-    });
-
-    it("should disallow other values", () => {
-      assert.throws(() => new JSDOM(``, { runScripts: null }), RangeError);
-      assert.throws(() => new JSDOM(``, { runScripts: "asdf" }), RangeError);
-      assert.throws(() => new JSDOM(``, { runScripts: true }), RangeError);
-      assert.throws(() => new JSDOM(``, { runScripts: false }), RangeError);
-    });
-  });
-
   describe("beforeParse", () => {
     it("should execute with a window and document but no nodes", () => {
       let windowPassed;

diff --git a/test/index.js b/test/index.js
@@ -10,6 +10,7 @@ require("./api/from-file.js");
 require("./api/from-url.js");
 require("./api/methods.js");
 require("./api/options.js");
+require("./api/options-run-scripts.js");
 require("./api/resources.js");
 require("./api/virtual-console.js");