diff --git a/src/Tmds.DBus.Protocol/VariantValue.cs b/src/Tmds.DBus.Protocol/VariantValue.cs index 6b62bf6..7d65b42 100644 --- a/src/Tmds.DBus.Protocol/VariantValue.cs +++ b/src/Tmds.DBus.Protocol/VariantValue.cs @@ -909,7 +909,7 @@ public KeyValuePair GetDictionaryEntry(int i) } var values = _o as KeyValuePair[]; - if (_o is null) + if (values is null) { ThrowCannotRetrieveAs(Type, VariantValueType.Dictionary); } @@ -1696,7 +1696,7 @@ public SignatureCheck(ReadOnlySpan signature) private static long GetStructVariantMask(ReadOnlySpan signature) { - signature = signature.Slice(1, signature.Length - 1); + signature = signature.Slice(1, signature.Length - 2); int i = 0; long mask = 0; while (TryReadSingleCompleteType(ref signature, out ReadOnlySpan itemSignature)) @@ -1898,7 +1898,7 @@ public VariantValueType ValueType internal VariantValueType GetStructFieldType(int index) { EnsureTypeIs(VariantValueType.Struct); - if (index < 0 || index > UnsafeCount) + if (index < 0 || index >= UnsafeCount) { throw new IndexOutOfRangeException(); } @@ -2070,7 +2070,7 @@ string TypeString(VariantValueType type, byte nesting) { 0 => $"[{type}{suffix}]", 1 => $"[{nameof(VariantValueType.Variant)}<{type}{suffix}>]", - _ => $"[{nameof(VariantValueType.Variant)}^{nesting}<{type}{suffix}]>" + _ => $"[{nameof(VariantValueType.Variant)}^{nesting}<{type}{suffix}>]" }; }