Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CVE-2024-23342 Timing Attack #330

Closed
yaronbenezra opened this issue Jan 24, 2024 · 4 comments
Closed

CVE-2024-23342 Timing Attack #330

yaronbenezra opened this issue Jan 24, 2024 · 4 comments
Labels
bug unintended behaviour in ecdsa code

Comments

@yaronbenezra
Copy link

yaronbenezra commented Jan 24, 2024

Hello,

SNYK and other scanning tools alerts on package vulnerability ( Timing Attack ) found at "sign_digest" API function.
( ecdsa.SigningKey.sign_digest() )

https://www.cve.org/CVERecord?id=CVE-2024-23342( HIGH Alert)

Can you address when you are going to fix this?

Regards,
Yaron

@maksimu
Copy link

maksimu commented Jan 24, 2024

We are also interesting is the ETA for the fix

@tomato42 tomato42 added the bug unintended behaviour in ecdsa code label Jan 24, 2024
@tomato42
Copy link
Member

as stated in the vulnerability release GHSA-wj6h-64fc-37mp and as stated in the security policy timing attacks are outside the scope of the project.

If you need an implementation that is safe against side-channel attacks, I recommend using https://github.com/pyca/cryptography

It's a won't fix.

@dlpzx
Copy link

dlpzx commented Feb 13, 2024

Hi @tomato42, can you give more details on what you mean by "timing attacks are outside the scope of the project."? Does it mean that ecdsa is not affected or just that resolving that vulnerability is responsibility of the users of ecdsa? Thanks

@tomato42
Copy link
Member

@dlpzx I mean that Python doesn't provide the primitives that are side-channel free, so it's impossible to build a side-channel free implementation on top of them. To actually fix it, it would require implementing the whole operation in C, which is a non-goal for the library (as it won't be a pure-python any more)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug unintended behaviour in ecdsa code
Projects
None yet
Development

No branches or pull requests

4 participants