Skip to content

Commit dbc5c26

Browse files
authored
Extra debug logging for RegressionIT (elastic#60272)
For elastic#59413
1 parent 13e2004 commit dbc5c26

File tree

1 file changed

+8
-1
lines changed
  • x-pack/plugin/ml/qa/native-multi-node-tests/src/test/java/org/elasticsearch/xpack/ml/integration

1 file changed

+8
-1
lines changed

x-pack/plugin/ml/qa/native-multi-node-tests/src/test/java/org/elasticsearch/xpack/ml/integration/RegressionIT.java

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@
3030

3131
import java.io.IOException;
3232
import java.time.Instant;
33+
import java.util.ArrayList;
3334
import java.util.List;
3435
import java.util.Map;
3536
import java.util.Set;
@@ -88,6 +89,9 @@ public void testSingleNumericFeatureAndMixedTrainingAndNonTrainingRows() throws
8889

8990
int trainingDocsWithEmptyFeatureImportance = 0;
9091
int testDocsWithEmptyFeatureImportance = 0;
92+
93+
// for debugging
94+
List<Map<String, Object>> badDocuments = new ArrayList<>();
9195
SearchResponse sourceData = client().prepareSearch(sourceIndex).setTrackTotalHits(true).setSize(1000).get();
9296
for (SearchHit hit : sourceData.getHits()) {
9397
Map<String, Object> destDoc = getDestDoc(config, hit);
@@ -107,6 +111,7 @@ public void testSingleNumericFeatureAndMixedTrainingAndNonTrainingRows() throws
107111
List<Map<String, Object>> importanceArray = (List<Map<String, Object>>)resultsObject.get("feature_importance");
108112

109113
if (importanceArray.isEmpty()) {
114+
badDocuments.add(destDoc);
110115
if (Boolean.TRUE.equals(resultsObject.get("is_training"))) {
111116
trainingDocsWithEmptyFeatureImportance++;
112117
} else {
@@ -126,7 +131,9 @@ public void testSingleNumericFeatureAndMixedTrainingAndNonTrainingRows() throws
126131
// If feature importance was empty for some of the docs this assertion helps us
127132
// understand whether the offending docs were training or test docs.
128133
assertThat("There were [" + trainingDocsWithEmptyFeatureImportance + "] training docs and ["
129-
+ testDocsWithEmptyFeatureImportance + "] test docs with empty feature importance",
134+
+ testDocsWithEmptyFeatureImportance + "] test docs with empty feature importance"
135+
+ " from " + sourceData.getHits().getTotalHits().value + " hits.\n"
136+
+ badDocuments,
130137
trainingDocsWithEmptyFeatureImportance + testDocsWithEmptyFeatureImportance, equalTo(0));
131138

132139
assertProgressComplete(jobId);

0 commit comments

Comments
 (0)