-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Insertion of image in table #25
Comments
It'd help if we could see the Markdown code which has this issue. |
from the slack message:
|
Did they try using HTML for the image instead? |
well that's what I suggested and that's what they ended up using http://juliaactuary.org/ // but I think here the issue is that they weren't sure how to do it so maybe we could test this ourselves first and then add an image in the table example. |
That's one beautiful page! Sure, let's find out what's the problem. |
Yeah :-) I'll add it here |
I encountered a similar issue today. I had defined a function
tried to call it from inside the Then I tried to manually inject the html inside the table, i.e. manually added Finally, I just put the plain html Hopefully this can help the bug hunt |
@lucaferranti the thing that's happening is that the table processing is deferred to CommonMark which does it better than Base.Markdown. And so there's some complexity in trying to capture things then sending some content to CommonMark then back to Franklin. Capturing individual cells and seeing if they contain specific commands is a bit annoying (though will be done in Franklin soon). Thanks for the feedback though, it's definitely something that should work eventually 😄 |
It was reported that inserting an image in a table might not work; this would need to be checked whether it's the figure environment which fails (it should though possibly more transparently than it currently does) or whether it's just that if commands are used in a table they're not going to be processed properly (likely) or whether standard markdown for an image also doesn't work (problematic)
The text was updated successfully, but these errors were encountered: