Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libaac does not work in android Marshmallow & above #30

Closed
madhu314 opened this issue Oct 17, 2016 · 3 comments
Closed

libaac does not work in android Marshmallow & above #30

madhu314 opened this issue Oct 17, 2016 · 3 comments

Comments

@madhu314
Copy link
Contributor

madhu314 commented Oct 17, 2016 •
edited
Loading

The library is running into issue-76 mentioned in the libaac repo

We need to update native so files and aac jar as mentioned in this comment

I have tested these changes and they work. I can submit a PR with the changes
@tlenclos
Copy link
Owner

Weird, it worked well for me, feel free to make a pull request.

I would love to replace aac with ExoPlayer though (see #12).

@madhu314
Copy link
Contributor Author

madhu314 commented Oct 18, 2016 •
edited
Loading

I have seen #12, I agree, having ExoPlayer is the best approach going forward.

In the mean time I will send out a PR for newer libs of aac

@madhu314 madhu314 mentioned this issue Oct 18, 2016
Merged
@tlenclos
Copy link
Owner

tlenclos commented Oct 24, 2016 •
edited
Loading

Fixed with release https://github.com/tlenclos/react-native-audio-streaming/releases/tag/v2.2.0, thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tlenclos @madhu314