Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we make notification on android and media center control on iOS optional ? #27

Closed
madhu314 opened this issue Oct 14, 2016 · 4 comments

Comments

@madhu314
Copy link
Contributor

Was wondering if the play method can take extra parameter to control notification on android and media center on ios ?

currently the default behavior is to always show notification and there is no way to override it ?

Are there any plans for such enhancements for this library ? I really like this library and hope to see this enhancement of optional notifications/media center control. If you agree, I can work on a PR

@tlenclos
Copy link
Owner

You are right this should be optional, you can work on it if you want. 😃

@madhu314
Copy link
Contributor Author

coool, I will give it a go.

@madhu314
Copy link
Contributor Author

I have submitted a PR , please have a look

@tlenclos
Copy link
Owner

Fixed with release https://github.com/tlenclos/react-native-audio-streaming/releases/tag/v2.2.0, thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants