[CI] Pin Cython to fix compilation error #184
Conversation
Cython 3.0.0 was recently released, but it is incompatible with the current .pxi definitions in python/tvm/_ffi/_cpython. Cython has been pinned for TVM in PR: 15353 until a working fix is created. This patch replicates many of the changes for TLCPack installation, as we are seeing the same Cython errors when trying to use TLCPack Ubuntu Docker images.
Pinning the Cython version for the CI wheel_winmac_nightly workflow to fix CI errors.
Liam-Sturge
force-pushed
the
Pin_Cython_to_fix_compilation_error
branch
from
0529a0b to
396a9df
Compare
|
Hi @Liam-Sturge, thanks for the PR fixing when packaging for cpu platforms. I see many other platforms are broken with a similar Cython related error. Would you mind creating an issue in this repo, so that the community can fix Conda, CUDA, etc? In the meantime, I can merge this change, as it at least guarantees that wheel on CPU works. |
Liam-Sturge
changed the title
Removes the Cython version pinning from Conda to separate the concerns in to a patch with clear scope.
|
I feel it is a good motivation to remove cython pining :) better to take a step forward than backward given both approaches seems to have some issues. Since rolling forward in a version would helps. Our experience suggests that windows is at least catching up with cython 3.0, we can skip MacOS conda flow for a bit |
|
I spend sometime to see if we can have a better way forward, apache/tvm#15469 should make the cython compatible to both 2.x and 3.0. In light of that, let move forward without pining. |
3 participants
Cython 3.0.0 was recently released, but it is incompatible with the current .pxi definitions in python/tvm/_ffi/_cpython.
Cython has been pinned for TVM in PR: 15353 until a working fix is created. This patch replicates many of the changes for TLCPack installation, as we are seeing the same Cython errors when trying to use TLCPack Ubuntu Docker images.
cc @leandron @areusch @konturn @Mousius @lhutton1 @tqchen