-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add b-tree example #147
Add b-tree example #147
Conversation
Would of course be appreciated if you added the spec to the repo itself instead of just a link! It's fine if you only want to add a link though. |
Considering the widespread use of B-trees in computer science education, would it be appropriate to label this as 'Beginner'? By the way, you will have to sign-off on the commit to pass the DCO check. |
.oO(This specification is an excellent candidate for creating an animation) |
Sure, I can add this directly to the repo. I'll revise my PR.
Yep, seems reasonable.
Will do.
I've never done animations with TLA+ before. I'll look through the existing specifications and see if I can figure out how to do that. |
Signed-off-by: Lorin Hochstein <[email protected]>
Signed-off-by: Lorin Hochstein <[email protected]>
Just a suggestion: have you considered refining, for example, the KV of https://github.com/tlaplus/Examples/tree/master/specifications/KeyValueStore or any other existing KV specification? Given how many database specs there are, it would be really nice to show that they all refine the same abstract KV. |
I think that might take a lot of work because I never wrote the KVStore spec with the intention of it being an abstract specification. In particular it focuses on implementing snapshot isolation, which I don't think is the case here. @lorin take a look at the README.md of this repo for instructions on how to onboard your spec & model to the manifest so it can be checked by the CI. |
Hi @lorin do you intend to see this PR through? Thanks! |
Signed-off-by: Lorin Hochstein <[email protected]>
Signed-off-by: Lorin Hochstein <[email protected]>
The title in the README "B-trees" is a foreign key that has to match the title in manifest "btree" |
Signed-off-by: Lorin Hochstein <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be nice to have a little blurb saying what this spec is and what interesting features or approaches it has!
Ooops the description also has to match. Sorry about that, I don't think the README table requirements are documented in the README directions itself. |
Oh you need to move your b-tree record to the first README table, the one of specs that are contained within the repository. Follow the format of others there. |
I'm going to close this one out for now, because I don't currently have the cycles to work on it. |
Add an entry for B-tree example.