Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add b-tree example #147

Closed
wants to merge 5 commits into from
Closed

Add b-tree example #147

wants to merge 5 commits into from

Conversation

lorin
Copy link

@lorin lorin commented Jul 12, 2024

Add an entry for B-tree example.

@ahelwer
Copy link
Collaborator

ahelwer commented Jul 12, 2024

Would of course be appreciated if you added the spec to the repo itself instead of just a link! It's fine if you only want to add a link though.

@lemmy
Copy link
Member

lemmy commented Jul 12, 2024

Considering the widespread use of B-trees in computer science education, would it be appropriate to label this as 'Beginner'?

By the way, you will have to sign-off on the commit to pass the DCO check.

@lemmy
Copy link
Member

lemmy commented Jul 12, 2024

.oO(This specification is an excellent candidate for creating an animation)

@lorin
Copy link
Author

lorin commented Jul 18, 2024

Would of course be appreciated if you added the spec to the repo itself instead of just a link! It's fine if you only want to add a link though.

Sure, I can add this directly to the repo. I'll revise my PR.

Considering the widespread use of B-trees in computer science education, would it be appropriate to label this as 'Beginner'?

Yep, seems reasonable.

By the way, you will have to sign-off on the commit to pass the DCO check.

Will do.

.oO(This specification is an excellent candidate for creating an animation)

I've never done animations with TLA+ before. I'll look through the existing specifications and see if I can figure out how to do that.

@lemmy
Copy link
Member

lemmy commented Jul 18, 2024

I've never done animations with TLA+ before. I'll look through the existing specifications and see if I can figure out how to do that.

In case you want to give it a try... Writing animation specifications is straightforward. There is a module that provides TLA+ definitions of SVG primitives. Below are a few examples. The first three are for TLC, and the other ones are for Will Schultz's TLA-web. Despite being for different systems, the definitions are quite similar.

https://github.com/tlaplus/Examples/blob/master/specifications/ewd998/EWD998_anim.tla
https://github.com/tlaplus/Examples/blob/master/specifications/ewd687a/EWD687a_anim.tla
https://github.com/tlaplus/Examples/blob/master/specifications/ewd840/EWD840_anim.tla
https://github.com/will62794/tla-web/blob/master/specs/EWD998.tla#L123-L201
https://github.com/will62794/tla-web/blob/master/specs/AbstractRaft_anim.tla#L210-L280

@lorin lorin marked this pull request as draft July 28, 2024 22:07
Signed-off-by: Lorin Hochstein <[email protected]>
Signed-off-by: Lorin Hochstein <[email protected]>
@lemmy
Copy link
Member

lemmy commented Jul 29, 2024

Just a suggestion: have you considered refining, for example, the KV of https://github.com/tlaplus/Examples/tree/master/specifications/KeyValueStore or any other existing KV specification? Given how many database specs there are, it would be really nice to show that they all refine the same abstract KV.

@ahelwer
Copy link
Collaborator

ahelwer commented Jul 29, 2024

I think that might take a lot of work because I never wrote the KVStore spec with the intention of it being an abstract specification. In particular it focuses on implementing snapshot isolation, which I don't think is the case here.

@lorin take a look at the README.md of this repo for instructions on how to onboard your spec & model to the manifest so it can be checked by the CI.

@ahelwer
Copy link
Collaborator

ahelwer commented Oct 15, 2024

Hi @lorin do you intend to see this PR through? Thanks!

@lorin
Copy link
Author

lorin commented Oct 17, 2024

Hi @lorin do you intend to see this PR through? Thanks!

Hey @ahelwer. Sorry, yes, I do intend to circle back to this at some point (maybe this week?)

Signed-off-by: Lorin Hochstein <[email protected]>
@lorin lorin marked this pull request as ready for review October 18, 2024 01:25
@ahelwer
Copy link
Collaborator

ahelwer commented Oct 18, 2024

The title in the README "B-trees" is a foreign key that has to match the title in manifest "btree"

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to have a little blurb saying what this spec is and what interesting features or approaches it has!

@ahelwer
Copy link
Collaborator

ahelwer commented Oct 19, 2024

Ooops the description also has to match. Sorry about that, I don't think the README table requirements are documented in the README directions itself.

@ahelwer
Copy link
Collaborator

ahelwer commented Oct 19, 2024

Oh you need to move your b-tree record to the first README table, the one of specs that are contained within the repository. Follow the format of others there.

@lorin
Copy link
Author

lorin commented Nov 4, 2024

I'm going to close this one out for now, because I don't currently have the cycles to work on it.

@lorin lorin closed this Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants